-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Enhanced Compilation Failure Issue #312
Conversation
Welcome @bfforever! It looks like this is your first PR to kmesh-net/kmesh 🎉 |
/ok-to-test |
|
Signed-off-by: kangmingfa <1640528278@qq.com>
time="2024-05-10T07:23:33Z" level=info msg="FLAG: --bpf-fs-path="/sys/fs/bpf"" subsys=manager |
Can be compiled and launched normally |
okay,I had followed with your commnds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer return pointer type
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix the Enhanced Compilation Failure Issue
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
#309
For enhanced kernel, without changing
BpfKmesh
to pointer type, would report an errorpkg/bpf/bpf.go:58:18: cannot use NewBpfKmesh(l.config) (value of type BpfKmesh) as *BpfKmesh value in assignment
at kmesh-daemon compile time.Does this PR introduce a user-facing change?: