Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Enhanced Compilation Failure Issue #312

Merged
merged 1 commit into from
May 11, 2024

Conversation

bfforever
Copy link
Member

@bfforever bfforever commented May 10, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:
Fix the Enhanced Compilation Failure Issue

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
#309
For enhanced kernel, without changing BpfKmesh to pointer type, would report an error pkg/bpf/bpf.go:58:18: cannot use NewBpfKmesh(l.config) (value of type BpfKmesh) as *BpfKmesh value in assignment at kmesh-daemon compile time.

Does this PR introduce a user-facing change?:


@kmesh-bot kmesh-bot added the kind/bug Something isn't working label May 10, 2024
@kmesh-bot
Copy link
Collaborator

Welcome @bfforever! It looks like this is your first PR to kmesh-net/kmesh 🎉

@hzxuzhonghu
Copy link
Member

/ok-to-test

@hzxuzhonghu
Copy link
Member

Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin kmesh-issues

Signed-off-by: kangmingfa <1640528278@qq.com>
@lec-bit
Copy link
Contributor

lec-bit commented May 10, 2024

time="2024-05-10T07:23:33Z" level=info msg="FLAG: --bpf-fs-path="/sys/fs/bpf"" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="FLAG: --cgroup2-path="/mnt/kmesh_cgroup2"" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="FLAG: --cni-etc-path="/etc/cni/net.d"" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="FLAG: --conflist-name=""" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="FLAG: --enable-mda="false"" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="FLAG: --help="false"" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="FLAG: --mode="workload"" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="FLAG: --plugin-cni-chained="true"" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="bpf Start successful" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="service node sidecar10.244.2.6kmesh-vpvg9.kmesh-system~kmesh-system.svc.cluster.local connect to discovery address istiod.istio-system.svc:15012" subsys=controller/config
time="2024-05-10T07:23:33Z" level=info msg="controller Start successful" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="dump StartServer successful" subsys=manager
time="2024-05-10T07:23:33Z" level=info msg="start write CNI config\n" subsys="cni installer"
time="2024-05-10T07:23:33Z" level=info msg="kmesh cni use chained\n" subsys="cni installer"
time="2024-05-10T07:23:36Z" level=info msg="Copied /usr/bin/kmesh-cni to /opt/cni/bin." subsys="cni installer"
time="2024-05-10T07:23:36Z" level=info msg="kubeconfig either does not exist or is out of date, writing a new one" subsys="cni installer"
time="2024-05-10T07:23:36Z" level=info msg="wrote kubeconfig file /etc/cni/net.d/kmesh-cni-kubeconfig" subsys="cni installer"
time="2024-05-10T07:23:36Z" level=info msg="cni config file: /etc/cni/net.d/10-kindnet.conflist" subsys="cni installer"
time="2024-05-10T07:23:36Z" level=info msg="command Start cni successful" subsys=manager

@lec-bit
Copy link
Contributor

lec-bit commented May 10, 2024

Can be compiled and launched normally

@bfforever
Copy link
Member Author

okay,I had followed with your commnds.

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer return pointer type

/lgtm

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 934284c into kmesh-net:main May 11, 2024
3 checks passed
@bfforever bfforever deleted the kmesh-issues branch May 20, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants