Use less move cron.CronJob from an instance variable to a package level singleton, to reduce the number of API calls #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for the awesome project.
I noticed when I have multiple accessories, this plugin makes API calls for each accessory resulting in 429 Too many requests error response from the API server, depending on the number of accessories and other API calls.
The response for /1/appliances and /1/devices include all the appliances and devices, so the API call can be once per accessory.
In this pull request I have moved the cron.CronJob from an instance variable of NatureRemoAircon to a package level variable so that multiple instances of NatureRemoAircon can use the single updater.