CIP-116 | Add feedback from query layer standardisation workshop #2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryun1
commented
Mar 6, 2024
•
Ryun1
commented
- small tidy/ corrections
- added "versioning" guidance
- added a changelog to be maintained
- fleshed out rationale
Ryun1
force-pushed
the
ryun1/json-spec-cip-workshop-feedback
branch
from
3cf4ccb
to
f127bf9
Compare
Ryun1
changed the title
klntsky
reviewed
Apr 18, 2024
klntsky
reviewed
Apr 18, 2024
klntsky
reviewed
Apr 18, 2024
klntsky
reviewed
Apr 18, 2024
klntsky
reviewed
Apr 18, 2024
klntsky
reviewed
Apr 18, 2024
|
|
||
| ### Acceptance Criteria | ||
|
|
||
| - [ ] One future ledger era schema is added | ||
| - [ ] This standard is implemented within three separate tools, libraries, etc. |
There was a problem hiding this comment.
Why three? Is this from some more general CIP guideline?
There was a problem hiding this comment.
Feel free to change, I feel like it is a fair number, there is no official guidelines it is up to the author
described here
klntsky
reviewed
Apr 18, 2024
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
klntsky
requested changes
May 3, 2024
Co-authored-by: Vladimir Kalnitsky <klntsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.