Commented out the attributes that are not implemented in Burrito

xml_converter/doc/fade/distance_fade_end.md

@@ -3,7 +3,8 @@ name: Distance Fade End
 type: Float32
 applies_to: [Icon, Trail]
 xml_fields: [FadeFar, DistanceFadeEnd]
-protobuf_field: distance_fade_end
+#151 This field should be set to 0 in the protobuf when equal to the default value
+protobuf_field: null #distance_fade_end
 examples:
   - "850"
   - "600"

xml_converter/doc/fade/distance_fade_start.md

@@ -3,7 +3,8 @@ name: Distance Fade Start
 type: Float32
 applies_to: [Icon, Trail]
 xml_fields: [FadeNear, DistanceFadeStart]
-protobuf_field: distance_fade_start
+#151 This field should be set to 0 in the protobuf when equal to the default value
+protobuf_field: null #distance_fade_start
 examples:
   - "650"
   - "400"

xml_converter/doc/position/height_offset.md

@@ -3,7 +3,8 @@ name: Height Offset
 type: Float32
 applies_to: ["Icon"]
 xml_fields: ["HeightOffset", "BHHeightOffset"]
-protobuf_field: height_offset
+#151 This field should be set to 0 in the protobuf when equal to the default value
+protobuf_field: null #height_offset
 examples:
   - "0"
 ---

xml_converter/doc/rendering/map_display_size.md

@@ -3,7 +3,8 @@ name: Map Display Size
 type: Int32
 applies_to: [Icon, Trail] 
 xml_fields: [MapDisplaySize]
-protobuf_field: map_display_size
+#151 This field should be set to 0 in the protobuf when equal to the default value
+protobuf_field: null #map_display_size
 ---
 The size, in pixels, that the marker should be shown on the minimap or fullscreen map.
 When applied to a Trail, affects the width of the trail shown on the minimap or fullscreen map.

xml_converter/doc/scale/icon_size.md

@@ -3,7 +3,8 @@ name: Icon Size
 type: Float32
 applies_to: [Icon]
 xml_fields: [IconSize]
-protobuf_field: tentative__scale
+#151 This field should be set to 0 in the protobuf when equal to the default value
+protobuf_field: null #tentative__scale
 ---
 Multiplier on the size of an image (i.e. 1 is 100%, 2 is 200%).
 

xml_converter/doc/scale/trail_scale.md

@@ -3,7 +3,8 @@ name: Trail Scale
 type: Float32
 applies_to: [Trail]
 xml_fields: [TrailScale]
-protobuf_field: scale
+#151 This field should be set to 0 in the protobuf when equal to the default value
+protobuf_field: null #scale
 ---
 Adjusts the width of a trail mesh as a multiplier to the default width.
 

xml_converter/doc/size_on_screen/maximum_size_on_screen.md

@@ -3,7 +3,8 @@ name: Maximum Size On Screen
 type: Int32
 applies_to: [Icon]
 xml_fields: [MaxSize]
-protobuf_field: maximum_size_on_screen
+#151 This field should be set to 0 in the protobuf when equal to the default value
+protobuf_field: null #maximum_size_on_screen
 ---
 The largest width/height of this icon on the screen.
 Notes

xml_converter/doc/size_on_screen/minimum_size_on_screen.md

@@ -3,7 +3,8 @@ name: Minimum Size on Screen
 type: Int32
 applies_to: [Icon]
 xml_fields: [MinSize]
-protobuf_field: minimum_size_on_screen
+#151 This field should be set to 0 in the protobuf when equal to the default value
+protobuf_field: null #minimum_size_on_screen
 ---
 The smallest width/height of this icon on the screen.
 

xml_converter/doc/texture/animation_speed.md

@@ -3,7 +3,8 @@ name: Animation Speed
 type: Float32
 applies_to: [Trail]
 xml_fields: ["AnimSpeed", "AnimationSpeed"]
-protobuf_field: animation_speed
+#151 This field should be set to 0 in the protobuf when equal to the default value
+protobuf_field: null #animation_speed
 ---
 The speed which the texture should be moving across the object.
 

xml_converter/doc/trigger/trigger_range.md

@@ -3,7 +3,8 @@ name: Trigger Range
 type: Float32
 applies_to: [Icon]
 xml_fields: [TriggerRange, InfoRange]
-protobuf_field: trigger.range
+#151 This field should be set to 0 in the protobuf when equal to the default value
+protobuf_field: null #trigger.range
 ---
 
 Used to indicate a trigger range. This attribute is used by multiple other attributes to define a distance from the marker in which those attributes will activate their functionality or behavior.

xml_converter/integration_tests/test_cases/xml_category_inheritance/input/pack/xml_file.xml

@@ -7,7 +7,7 @@
         </MarkerCategory>
     </MarkerCategory>
 
-    <MarkerCategory Name="TrailNestedLevel1" Texture="texture_one.png" TrailData="trail.trl" AnimationSpeed="1">
+    <MarkerCategory Name="TrailNestedLevel1" Texture="texture_one.png" TrailData="trail.trl">
         <MarkerCategory Name="TrailNestedLevel2"></MarkerCategory>
     </MarkerCategory>
 

xml_converter/integration_tests/test_cases/xml_category_inheritance/output_xml/xml_file.xml

@@ -21,6 +21,6 @@
 <POI  Type="nestedlevel1" MapID="50" XPos="111.000000" YPos="0.000000" ZPos="0.000000"/>
 <POI  Type="nestedlevel1.nestedlevel2" MapID="50" XPos="111.000000" YPos="222.000000" ZPos="0.000000"/>
 <POI  Type="nestedlevel1.nestedlevel2.nestedlevel3" MapID="50" XPos="111.000000" YPos="222.000000" ZPos="333.000000"/>
-<Trail  AnimSpeed="1.000000" Type="trailnestedlevel1.trailnestedlevel2" MapID="50" Texture="texture_one.png" TrailData="037aa160e392f1c8.trl"/>
+<Trail  Type="trailnestedlevel1.trailnestedlevel2" MapID="50" Texture="texture_one.png" TrailData="037aa160e392f1c8.trl"/>
 </POIs>
 </OverlayData>

xml_converter/proto/guildpoint.proto

@@ -30,9 +30,9 @@ message Icon {
     uint32 texture_id = 2;
     bytes guid = 3;
     int32 map_id = 4;
-    float distance_fade_end = 5;
-    float distance_fade_start = 6;
-    float height_offset= 7;
+    // float distance_fade_end = 5;
+    // float distance_fade_start = 6;
+    // float height_offset= 7;
     Position position = 8;
     Trigger trigger = 9;
     EulerRotation euler_rotation = 10;
@@ -41,9 +41,9 @@ message Icon {
     int32 achievement_bit_index = 17;
 
     bool disable_player_cutout = 19;
-    int32 minimum_size_on_screen = 20;
-    int32 map_display_size = 21;
-    int32 maximum_size_on_screen = 22;
+    // int32 minimum_size_on_screen = 20;
+    // int32 map_display_size = 21;
+    // int32 maximum_size_on_screen = 22;
     bool constant_size_on_map = 23;
     string tip_description = 24;
     string tip_name = 25;
@@ -59,7 +59,7 @@ message Icon {
     bool is_hidden_on_map = 35;
     bool is_hidden_on_minimap = 36;
 
-    float tentative__scale = 2048;
+    // float tentative__scale = 2048;
     string bhdraft__schedule = 2052;
     float bhdraft__schedule_duration = 2053;
 }
@@ -68,24 +68,24 @@ message Trail {
     uint32 texture_id = 2;
     bytes guid = 3;
     int32 map_id = 4;
-    float distance_fade_end = 5;
-    float distance_fade_start = 6;
+    // float distance_fade_end = 5;
+    // float distance_fade_start = 6;
     TrailData trail_data = 7;
-    float animation_speed = 8;
+    // float animation_speed = 8;
 
     int32 achievement_id = 16;
     int32 achievement_bit_index = 17;
     bool disable_player_cutout = 19;
     bool is_wall = 20;
-    float scale = 21;
+    // float scale = 21;
     fixed32 rgba_color = 22;
     FestivalFilter festival_filter = 23;
     MapTypeFilter map_type_filter = 24;
     MountFilter mount_filter = 25;
     ProfessionFilter profession_filter = 26;
     SpecializationFilter specialization_filter = 27;
     SpeciesFilter species_filter = 28;
-    int32 map_display_size = 29;
+    // int32 map_display_size = 29;
     CullChirality cull_chirality = 30;
     bool is_hidden_ingame = 31;
     bool is_hidden_on_map = 32;
@@ -118,7 +118,7 @@ message Trigger {
     string action_info_message = 8;
     bool invert_display = 9;
     float reset_length = 10;
-    float range = 11;
+    // float range = 11;
     Category action_hide_category = 12;
     Category action_show_category = 13;
     Category action_toggle_category = 14;