feat: upgrade eslint

eslint.config.js

@@ -21,7 +21,8 @@ export default [
       "file-progress/activate": 1,
       "@typescript-eslint/no-non-null-assertion": "off",
       "@typescript-eslint/class-methods-use-this": "off",
-      "@typescript-eslint/max-params": "off"
+      "@typescript-eslint/max-params": "off",
+      "@typescript-eslint/no-magic-numbers": "off"
     }
   }
 ]

package.json

@@ -74,7 +74,7 @@
     "cross-env": "^7.0.3",
     "dts-bundle-generator": "^9.5.1",
     "eslint": "^8.57.0",
-    "eslint-config-love": "^64.0.0",
+    "eslint-config-love": "^87.0.0",
     "eslint-plugin-file-progress": "^1.5.0",
     "fs-extra": "^11.2.0",
     "gh-pages": "^6.1.1",

src/common/Action.ts

@@ -30,15 +30,15 @@ export default class Action {
   private _callbacks: ActionCallback[] = []
 
   subscribe (callback: ActionCallback): void {
-    const index = this._callbacks.indexOf(callback) ?? -1
+    const index = this._callbacks.indexOf(callback)
     if (index < 0) {
       this._callbacks.push(callback)
     }
   }
 
   unsubscribe (callback?: ActionCallback): void {
     if (isFunction(callback)) {
-      const index = this._callbacks.indexOf(callback) ?? -1
+      const index = this._callbacks.indexOf(callback)
       if (index > -1) {
         this._callbacks.splice(index, 1)
       }

src/common/Canvas.ts

@@ -67,7 +67,7 @@ export default class Canvas {
       if (result) {
         this._resizeObserver = new ResizeObserver((entries: ResizeObserverEntry[]) => {
           const entry = entries.find((entry: ResizeObserverEntry) => entry.target === this._element)
-          const size = entry?.devicePixelContentBoxSize?.[0]
+          const size = entry?.devicePixelContentBoxSize[0]
           if (isValid(size)) {
             this._nextPixelWidth = size.inlineSize
             this._nextPixelHeight = size.blockSize
@@ -136,8 +136,8 @@ export default class Canvas {
   }
 
   destroy (): void {
-    this._resizeObserver?.unobserve(this._element)
+    this._resizeObserver.unobserve(this._element)
     // eslint-disable-next-line @typescript-eslint/no-deprecated
-    this._mediaQueryList?.removeListener(this._mediaQueryListener)
+    this._mediaQueryList.removeListener(this._mediaQueryListener)
   }
 }

src/common/SyntheticEvent.ts

@@ -88,19 +88,17 @@ const enum Delay {
   PreventFiresTouchEvents = 500,
 }
 
-const enum ManhattanDistance {
-  CancelClick = 5,
-  // eslint-disable-next-line @typescript-eslint/no-duplicate-enum-values
-  CancelTap = 5,
-  // eslint-disable-next-line @typescript-eslint/no-duplicate-enum-values
-  DoubleClick = 5,
-  DoubleTap = 30,
+const ManhattanDistance = {
+  CancelClick: 5,
+  CancelTap: 5,
+  DoubleClick: 5,
+  DoubleTap: 30,
 }
 
-const enum MouseEventButton {
-  Left = 0,
-  Middle = 1,
-  Right = 2,
+const MouseEventButton = {
+  Left: 0,
+  Middle: 1,
+  Right: 2,
 }
 
 export const TOUCH_MIN_RADIUS = 10
@@ -231,18 +229,21 @@ export default class SyntheticEvent {
     this._unsubscribeMouseWheel?.()
     this._unsubscribeContextMenu?.()
 
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const boundMouseMoveHandler = this._mouseMoveHandler.bind(this)
     this._unsubscribeMousemove = () => {
       this._target.removeEventListener('mousemove', boundMouseMoveHandler)
     }
     this._target.addEventListener('mousemove', boundMouseMoveHandler)
 
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const boundMouseWheel = this._mouseWheelHandler.bind(this)
     this._unsubscribeMouseWheel = () => {
       this._target.removeEventListener('wheel', boundMouseWheel)
     }
     this._target.addEventListener('wheel', boundMouseWheel, { passive: false })
 
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const boundContextMenu = this._contextMenuHandler.bind(this)
     this._unsubscribeContextMenu = () => {
       this._target.removeEventListener('contextmenu', boundContextMenu)
@@ -353,6 +354,7 @@ export default class SyntheticEvent {
     const moveInfo = this._mouseTouchMoveWithDownInfo(this._getCoordinate(touch), this._touchMoveStartCoordinate!)
     const { xOffset, yOffset, manhattanDistance } = moveInfo
 
+
     if (!this._touchMoveExceededManhattanDistance && manhattanDistance < ManhattanDistance.CancelTap) {
       return
     }
@@ -392,13 +394,15 @@ export default class SyntheticEvent {
   }
 
   private _mouseMoveWithDownHandler (moveEvent: MouseEvent): void {
+
     if (moveEvent.button !== MouseEventButton.Left) {
       return
     }
 
     const moveInfo = this._mouseTouchMoveWithDownInfo(this._getCoordinate(moveEvent), this._mouseMoveStartCoordinate!)
     const { manhattanDistance } = moveInfo
 
+
     if (manhattanDistance >= ManhattanDistance.CancelClick) {
       // if manhattan distance is more that 5 - we should cancel click event
       this._cancelClick = true
@@ -441,6 +445,7 @@ export default class SyntheticEvent {
 
       if (this._tapTimeoutId !== null && this._tapCount > 1) {
         const { manhattanDistance } = this._mouseTouchMoveWithDownInfo(this._getCoordinate(dblClickEvent), this._tapCoordinate)
+
         if (manhattanDistance < ManhattanDistance.DoubleTap && !this._cancelTap) {
           this._processEvent(this._makeCompatEvent(dblClickEvent), this._handler.doubleTapEvent)
         }
@@ -451,6 +456,7 @@ export default class SyntheticEvent {
 
       if (this._clickTimeoutId !== null && this._clickCount > 1) {
         const { manhattanDistance } = this._mouseTouchMoveWithDownInfo(this._getCoordinate(dblClickEvent), this._clickCoordinate)
+
         if (manhattanDistance < ManhattanDistance.DoubleClick && !this._cancelClick) {
           this._processEvent(this._makeCompatEvent(dblClickEvent), this._handler.mouseDoubleClickEvent)
         }
@@ -459,7 +465,7 @@ export default class SyntheticEvent {
     }
   }
 
-  // eslint-disable-next-line complexity
+   
   private _touchEndHandler (touchEndEvent: TouchEvent): void {
     let touch = this._touchWithId(touchEndEvent.changedTouches, this._activeTouchId)
     if (touch === null && touchEndEvent.touches.length === 0) {
@@ -593,7 +599,9 @@ export default class SyntheticEvent {
     }
 
     {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       const boundTouchMoveWithDownHandler = this._touchMoveHandler.bind(this)
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       const boundTouchEndHandler = this._touchEndHandler.bind(this)
 
       this._unsubscribeRootTouchEvents = () => {
@@ -643,7 +651,9 @@ export default class SyntheticEvent {
     }
 
     {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       const boundMouseMoveWithDownHandler = this._mouseMoveWithDownHandler.bind(this)
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       const boundMouseUpHandler = this._mouseUpHandler.bind(this)
 
       this._unsubscribeRootMouseEvents = () => {
@@ -787,7 +797,7 @@ export default class SyntheticEvent {
   }
 
   private _startPinch (touches: TouchList): void {
-    const box = this._target.getBoundingClientRect() ?? { left: 0, top: 0 }
+    const box = this._target.getBoundingClientRect()
     this._startPinchMiddleCoordinate = {
       x: ((touches[0].clientX - box.left) + (touches[1].clientX - box.left)) / 2,
       y: ((touches[0].clientY - box.top) + (touches[1].clientY - box.top)) / 2
@@ -851,9 +861,11 @@ export default class SyntheticEvent {
   private _firesTouchEvents (e: MouseEvent): boolean {
     // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-expect-error
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
     if (isValid(e.sourceCapabilities?.firesTouchEvents)) {
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-expect-error
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
       return e.sourceCapabilities.firesTouchEvents
     }
 
@@ -868,7 +880,7 @@ export default class SyntheticEvent {
     // TouchEvent has no clientX/Y coordinates:
     // We have to use the last Touch instead
     const eventLike = touch ?? (event as MouseEvent)
-    const box = this._target.getBoundingClientRect() ?? { left: 0, top: 0 }
+    const box = this._target.getBoundingClientRect()
     return {
       x: eventLike.clientX - box.left,
       y: eventLike.clientY - box.top,
@@ -907,6 +919,7 @@ export default class SyntheticEvent {
 
   private _eventTimeStamp (e: TouchEvent | MouseEvent): number {
     // for some reason e.timestamp is always 0 on iPad with magic mouse, so we use performance.now() as a fallback
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     return e.timeStamp ?? performance.now()
   }
 

src/common/utils/canvas.ts

@@ -23,7 +23,7 @@ let measureCtx: Nullable<CanvasRenderingContext2D> = null
  * @returns {number}
  */
 export function getPixelRatio (canvas: HTMLCanvasElement): number {
-  return canvas.ownerDocument?.defaultView?.devicePixelRatio ?? 1
+  return canvas.ownerDocument.defaultView?.devicePixelRatio ?? 1
 }
 
 export function createFont (size?: number, weight?: string | number, family?: string): string {

src/common/utils/number.ts

@@ -75,26 +75,23 @@ export function nice (value: number): number {
     nf = 8
   }
   value = nf * exp10
-  return exponent >= -20 ? +value.toFixed(exponent < 0 ? -exponent : 0) : value
+  return +value.toFixed(Math.abs(exponent))
 }
 
 /**
- * 四舍五入
+ * Round
  * @param value
  * @param precision
  * @return {number}
  */
-export function round (value: number, precision: number): number {
-  if (precision == null) {
-    precision = 10
-  }
-  precision = Math.min(Math.max(0, precision), 20)
-  const v = (+value).toFixed(precision)
-  return +v
+export function round (value: number, precision?: number): number {
+  precision = Math.max(0, precision ?? 0)
+  const pow = Math.pow(10, precision)
+  return Math.round(value * pow) / pow
 }
 
 /**
- * 获取小数位数
+ * Get precision
  * @param value
  * @return {number|number}
  */
@@ -104,10 +101,9 @@ export function getPrecision (value: number): number {
   if (eIndex > 0) {
     const precision = +str.slice(eIndex + 1)
     return precision < 0 ? -precision : 0
-  } else {
-    const dotIndex = str.indexOf('.')
-    return dotIndex < 0 ? 0 : str.length - 1 - dotIndex
   }
+  const dotIndex = str.indexOf('.')
+  return dotIndex < 0 ? 0 : str.length - 1 - dotIndex
 }
 
 export function getMaxMin<D> (dataList: D[], maxKey: keyof D, minKey: keyof D): number[] {
@@ -116,15 +112,15 @@ export function getMaxMin<D> (dataList: D[], maxKey: keyof D, minKey: keyof D):
   let index = 0
   while (index < dataLength) {
     const data = dataList[index]
-    maxMin[0] = Math.max((data[maxKey] ?? data) as number, maxMin[0])
-    maxMin[1] = Math.min((data[minKey] ?? data) as number, maxMin[1])
+    maxMin[0] = Math.max((data[maxKey] ?? Number.MIN_SAFE_INTEGER) as number, maxMin[0])
+    maxMin[1] = Math.min((data[minKey] ?? Number.MAX_SAFE_INTEGER) as number, maxMin[1])
     ++index
   }
   return maxMin
 }
 
 /**
- * 10为底的对数函数
+ * log10
  * @param value
  * @return {number}
  */
@@ -133,7 +129,7 @@ export function log10 (value: number): number {
 }
 
 /**
- * 10的指数函数
+ * index 10
  * @param value
  * @return {number}
  */

src/component/Axis.ts

@@ -117,19 +117,19 @@ export default abstract class AxisImp implements Axis {
   scrollZoomEnabled = true
   createTicks: AxisCreateTicksCallback
 
-  private readonly _parent: DrawPane<Axis>
+  private readonly _parent: DrawPane
 
   private _range = getDefaultAxisRange()
   private _prevRange = getDefaultAxisRange()
   private _ticks: AxisTick[] = []
 
   private _autoCalcTickFlag = true
 
-  constructor (parent: DrawPane<Axis>) {
+  constructor (parent: DrawPane) {
     this._parent = parent
   }
 
-  getParent (): DrawPane<Axis> { return this._parent }
+  getParent (): DrawPane { return this._parent }
 
   buildTicks (force: boolean): boolean {
     if (this._autoCalcTickFlag) {

src/component/Indicator.ts

@@ -248,7 +248,6 @@ export type IndicatorConstructor<D = unknown> = new () => IndicatorImp<D>
 
 export type EachFigureCallback<D> = (figure: IndicatorFigure<D>, figureStyles: IndicatorFigureStyle, index: number) => void
 
-// eslint-disable-next-line @typescript-eslint/max-params
 export function eachFigures<D = unknown> (
   kLineDataList: KLineData[],
   indicator: Indicator<D>,
@@ -382,6 +381,7 @@ export default class IndicatorImp<D = unknown> implements Indicator<D> {
     if (!isString(this.name)) {
       this.name = name ?? ''
     }
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     this.shortName = shortName ?? this.shortName ?? this.name
     if (isNumber(precision)) {
       this.precision = precision

src/component/XAxis.ts

@@ -29,10 +29,10 @@ export interface XAxis extends Axis, Required<XAxisTemplate> {
   convertTimestampToPixel: (timestamp: number) => number
 }
 
-export type XAxisConstructor = new (parent: DrawPane<Axis>) => XAxis
+export type XAxisConstructor = new (parent: DrawPane) => XAxis
 
 export default abstract class XAxisImp extends AxisImp implements XAxis {
-  constructor (parent: DrawPane<Axis>, xAxis: XAxisTemplate) {
+  constructor (parent: DrawPane, xAxis: XAxisTemplate) {
     super(parent)
     this.override(xAxis)
   }
@@ -179,7 +179,7 @@ export default abstract class XAxisImp extends AxisImp implements XAxis {
 
   static extend (template: XAxisTemplate): XAxisConstructor {
     class Custom extends XAxisImp {
-      constructor (parent: DrawPane<Axis>) {
+      constructor (parent: DrawPane) {
         super(parent, template)
       }
     }