Skip to content

Commit

Permalink
Update Emscripten Docker image to 3.1.63
Browse files Browse the repository at this point in the history
  • Loading branch information
kleisauke committed Jul 13, 2024
1 parent f153556 commit 5e3e0f7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [v0.0.10] - TBD

Uses libvips v8.15.2, compiled with Emscripten v3.1.62.
Uses libvips v8.15.2, compiled with Emscripten v3.1.63.

## [v0.0.9] - 2024-06-01

Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# https://github.com/emscripten-core/emsdk
FROM docker.io/emscripten/emsdk:3.1.62
FROM docker.io/emscripten/emsdk:3.1.63

# Path settings
ENV \
Expand All @@ -24,7 +24,7 @@ RUN \

# Emscripten patches
RUN \
curl -Ls https://github.com/emscripten-core/emscripten/compare/3.1.62...kleisauke:wasm-vips-3.1.62.patch | patch -p1 -d $EMSDK/upstream/emscripten && \
curl -Ls https://github.com/emscripten-core/emscripten/compare/3.1.63...kleisauke:wasm-vips-3.1.63.patch | patch -p1 -d $EMSDK/upstream/emscripten && \
emcc --clear-cache && embuilder build sysroot --force

This comment has been minimized.

Copy link
@marcosc90

marcosc90 Jul 21, 2024

Contributor

FYI @kleisauke upgrading to 3.1.63 breaks vite builds with:

Circular worker imports detected. Vite does not support it

Because of the change here:
https://github.com/emscripten-core/emscripten/blob/a1fe3902bf73a3802eae0357d273d0e37ea79898/src/library_pthread.js#L460

This comment has been minimized.

Copy link
@kleisauke

kleisauke Jul 23, 2024

Author Owner

I just reverted that change in the emscripten-core/emscripten@3.1.64...kleisauke:wasm-vips-3.1.64 changeset with commit kleisauke/emscripten@cdb2524.

Thanks for reporting!


# Rust
Expand Down

0 comments on commit 5e3e0f7

Please sign in to comment.