adding isAjax() method to Request.

[andreyvital]

No description provided.

[unstoppablecarl]

Shouldn't this line not have ! ?
https://github.com/chriso/klein.php/pull/236/files#diff-ef08190048a14ce65d4bd2bb022ca5ddR412

[Rican7]

The tests did die on your new addition, if you check the output here.
Its because of your non PSR-2 compliant code style (your foreach( needs to be a foreach (). You're also using short-array syntax (5.4+ only) in a PHP 5.3 compatible library, which won't pass.

As far as why I tagged this as "May Not Implement", its because I wanted to do some more research into the reliability of this method checking an actual AJAX call. I've found out a few things:

• I nearly forgot, but we've talked about detecting XHR before
• Checking based on a header alone isn't reliable, as the header could be manually overwritten. The use case I see most often applying this feature request to is for some layer of security checking, and this would be a false security measure
• The X-Requested-With header is non-standard (hence the X- prefix), and is not implemented by most browsers. This header is mostly a jQuery thing, and other frameworks/libraries that have used it in the past have since removed it

So, as you can see, this method would be a nice convenience if it were accurate/dependable. Unfortunately, its based on something added in by a particular JavaScript framework, and therefore isn't something I think would make sense to add to the base library.