Reporting cav changes to develop #383
Conversation
TomGallon
changed the title
| @@ -48,14 +48,14 @@ function loadList(listDesc) { | |||
| * @param {string} listName - The name of the list to load. | |||
| * @param {object} args - Argument to provide to the function. | |||
| */ | |||
| function loadListByName(listName, args) { | |||
| function loadListByName(listName, args, skipCache) { | |||
There was a problem hiding this comment.
put a value by default please, to ensure that's still work for all projects
There was a problem hiding this comment.
@JohnnP is this the unacessible argument ?
There was a problem hiding this comment.
In fact no, the method is export so it's necessary to put a default value.
| @@ -70,7 +70,7 @@ function loadListByName(listName, args) { | |||
| //Load many lists by their names. `refHelper.loadMany(['list1', 'list2']).then(success, error)` | |||
| // Return an array of many promises for all the given lists. | |||
| // Be carefull, if there is a problem for one list, the error callback is called. | |||
| function loadMany(names) { | |||
| function loadMany(names, skipCache) { | |||
There was a problem hiding this comment.
put a value by default please, to ensure that's still work for all projects
| dispatcher.handleViewAction({data: err, type: 'error'}); | ||
| }); | ||
| }; | ||
| function builtInReferenceAction(referenceNames, skipCache) { |
There was a problem hiding this comment.
put a value by default please, to ensure that's still work for all projects
There was a problem hiding this comment.
this one have to be set to false
GuenoleK
force-pushed
the
cherry-pick-cav
branch
from
8002cd3 to
dae5cae
Compare
|
@JohnnP can you do a little review here to explain which function from @TomGallon comments can have a default set and which one we have to not touch because it is used on another function please ? I will do the modifictions. Do not hesistate to comment on @TomGallon also. |
|
@JohnnP perfect thanks |
GuenoleK
force-pushed
the
cherry-pick-cav
branch
from
567b955 to
2c19d8d
Compare
No description provided.