Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Fix intermittent failure of TestWalletNotifications #1314

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

aidan-kwon
Copy link
Member

Proposed changes

TestWalletNotifications intermittently fails if the event collector goroutine is closed before receiving all events. The fix checks and receives unhandled events.
The change is imported from ethereum/go-ethereum#21703

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@aidan-kwon aidan-kwon merged commit 8ad2278 into klaytn:dev Apr 13, 2022
@aidan-kwon aidan-kwon deleted the 220408-fixTestWallet branch April 13, 2022 02:14
aidan-kwon pushed a commit to aidan-kwon/klaytn that referenced this pull request Apr 19, 2022
Fix intermittent failure of TestWalletNotifications
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants