Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add custom deployment network #686

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

ftupas
Copy link
Contributor

@ftupas ftupas commented Aug 22, 2023

Time spent on this PR: 0

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #

What is the new behavior?

  • Allow deployer account to be deployed on custom networks

Other information

Added changes to CHANGELOG.md

  • Yes
  • No

@ftupas ftupas self-assigned this Aug 22, 2023
@ftupas ftupas requested a review from bajpai244 August 22, 2023 13:11
@Eikix Eikix enabled auto-merge August 22, 2023 13:29
@Eikix Eikix added this pull request to the merge queue Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9773e4d) 80.57% compared to head (abd60d0) 80.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files          44       44           
  Lines        7298     7298           
=======================================
  Hits         5880     5880           
  Misses       1418     1418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 22, 2023
@ftupas ftupas added this pull request to the merge queue Aug 22, 2023
@ftupas ftupas removed this pull request from the merge queue due to a manual request Aug 22, 2023
@Eikix Eikix merged commit ee6458a into kkrt-labs:main Aug 22, 2023
7 of 8 checks passed
@ftupas ftupas deleted the dev/add-custom-deployment-network branch August 22, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants