This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obatirou
reviewed
Oct 16, 2024
obatirou
reviewed
Oct 16, 2024
solidity_contracts/src/CairoPrecompiles/CallCairoPrecompileTest.sol
Outdated
Show resolved
Hide resolved
solidity_contracts/src/CairoPrecompiles/MulticallCairoPrecompileTest.sol
Show resolved
Hide resolved
solidity_contracts/src/CairoPrecompiles/MulticallCairoPrecompileTest.sol
Show resolved
Hide resolved
solidity_contracts/src/CairoPrecompiles/MulticallCairoPrecompileTest.sol
Show resolved
Hide resolved
solidity_contracts/src/CairoPrecompiles/SubContextPrecompile.sol
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_call_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_call_cairo_precompile.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/CairoPrecompiles/test_call_cairo_precompile.py
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
=====================================
Coverage 61.8% 61.8%
=====================================
Files 44 44
Lines 8327 8335 +8
=====================================
+ Hits 5148 5157 +9
+ Misses 3179 3178 -1 ☔ View full report in Codecov by Sentry. |
ClementWalter
approved these changes
Oct 16, 2024
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A public cairo_call precompile at address 0x75004, with delegate/callcode disabled.
reworked a bit the solidity contracts that are used solely for testing purposed.
todo next:
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)