This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.5 days
Pull request type: Bugfix
What is the current behavior?
Resolves #1: Handling
deployerPrivateKey
might throw an error if it's set to 0If the
deployerPrivateKey
is null, it could lead to improper handling or unexpected behavior when callingvm.startBroadcast
.Resolves #2: Missing success checks for contract calls
There are no success checks for the
Counter
andPlainOpcodes
contract calls. If the contract deployment fails, it won't be explicitly logged.Resolves #3: Type issue in the
create
functionThe
create
function is called withtype(Counter).creationCode
, which returns the contract bytecode. However, it's unclear if the expected argument forcreate
matches this return value. In thePlainOpcodes
contract,create
might expect different data types (e.g., hashes or precompiled codes)."What is the new behavior?
create
expects bytecode, and the passed value is correct. If an address or hash is needed, adjust the parameter.This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)