Implement Candidate for str

[gwenn]

Should fix #443

[LoganDark]

How exactly am I expected to provide a vector of str? They're literally DSTs.

[gwenn]

How exactly am I expected to provide a vector of str? They're literally DSTs.

Please provide a minimal example that should but doesn't work.

[LoganDark]

How exactly am I expected to provide a vector of str? They're literally DSTs.

Please provide a minimal example that should but doesn't work.

impl Completer for LineHelper {
	type Candidate = &'static str;

	fn complete(
		&self,
		_line: &str,
		_pos: usize,
		_ctx: &rustyline::Context<'_>,
	) -> rustyline::Result<(usize, Vec<Self::Candidate>)> {
		Ok((0, vec!["test1", "test2"]))
	}
}

[gwenn]

How exactly am I expected to provide a vector of str? They're literally DSTs.

Please provide a minimal example that should but doesn't work.

impl Completer for LineHelper {
	type Candidate = &'static str;

	fn complete(
		&self,
		_line: &str,
		_pos: usize,
		_ctx: &rustyline::Context<'_>,
	) -> rustyline::Result<(usize, Vec<Self::Candidate>)> {
		Ok((0, vec!["test1", "test2"]))
	}
}

Candidate should be str: type Candidate = str;

[LoganDark]

How exactly am I expected to provide a vector of str? They're literally DSTs.

Please provide a minimal example that should but doesn't work.

impl Completer for LineHelper {
	type Candidate = &'static str;

	fn complete(
		&self,
		_line: &str,
		_pos: usize,
		_ctx: &rustyline::Context<'_>,
	) -> rustyline::Result<(usize, Vec<Self::Candidate>)> {
		Ok((0, vec!["test1", "test2"]))
	}
}

Candidate should be str: type Candidate = str;

Exactly, and then I can't return a Vec<Self::Candidate> because str is a DST. Try it yourself.

The issue is that str is unusable as a candidate because it is not Sized. But I can't use &str as the candidate because you only implement Candidate for str itself.

[gwenn]

How exactly am I expected to provide a vector of str? They're literally DSTs.

Please provide a minimal example that should but doesn't work.

impl Completer for LineHelper {
	type Candidate = &'static str;

	fn complete(
		&self,
		_line: &str,
		_pos: usize,
		_ctx: &rustyline::Context<'_>,
	) -> rustyline::Result<(usize, Vec<Self::Candidate>)> {
		Ok((0, vec!["test1", "test2"]))
	}
}

Candidate should be str: type Candidate = str;

Exactly, and then I can't return a Vec<Self::Candidate> because str is a DST. Try it yourself.

The issue is that str is unusable as a candidate because it is not Sized. But I can't use &str as the candidate because you only implement Candidate for str itself.

You are right.
And I don't remember why I provided an impl for str and not:

impl Candidate for &'static str {
    fn display(&self) -> &str {
        self
    }

    fn replacement(&self) -> &str {
        self
    }
}

[LoganDark]

You are right.
And I don't remember why I provided an impl for str and not:

impl Candidate for &'static str {
    fn display(&self) -> &str {
        self
    }

    fn replacement(&self) -> &str {
        self
    }
}

I believe it was because you (or someone) raised concerns about only supporting 'static and not other lifetimes. But changing that would mean rustyline v9.0.0, so...

[gwenn]

I believe it was because you (or someone) raised concerns about only supporting 'static and not other lifetimes. But changing that would mean rustyline v9.0.0, so...

No, we can still patch v8 and provide an impl for &'static str (and keep the old / unusable one).
See #512

[LoganDark]

I believe it was because you (or someone) raised concerns about only supporting 'static and not other lifetimes. But changing that would mean rustyline v9.0.0, so...

No, we can still patch v8 and provide an impl for &'static str (and keep the old / unusable one).
See #512

I meant supporting other lifetimes would mean v9, so yeah, supporting static can be done here.