Does clearing screen reset background also

[sophiajt]

Recently, we had someone file this issue for nushell: nushell/nushell#1599

It seems as though when they use the clear screen shortcut, rustyline is able to clear the screen. But, when there's a background color (like the red we use for errors), that doesn't get cleared.

Is there a way to enable clearing the background also?

[bjorn3]

Unix uses \x1b[H\x1b[2J which clears the background:

rustyline/src/tty/unix.rs

Line 656 in cbedcf1

self.write_and_flush(b"\x1b[H\x1b[2J")

Windows uses FillConsoleOutputCharacterA to fill the screen with spaces. It seems that this doesn't affect colors. According to https://docs.microsoft.com/en-us/windows/console/clearing-the-screen you need to call FillConsoleOutputAttribute as well.

rustyline/src/tty/windows.rs

Lines 292 to 298 in d95cd7c

	check!(wincon::FillConsoleOutputCharacterA(
	self.handle,
	' ' as CHAR,
	length,
	pos,
	&mut _count,
	));

[gwenn]

Indeed, we should do both like

• Haskeline
• Linefeed
• python-prompt-toolkit

[gwenn]

Could you please give a try to PR #367 ?
Thanks.

[sophiajt]

Yes, this looks better. I couldn't get it to repro with this PR.

[sophiajt]

@gwenn - can we merge this fix for the next release, too?

[gwenn]

@jonathandturner 6.1.2 has been published.