Only set :endpoint from legacy option if present (AwsSdkAdapter) #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `aws-sdk-core` gem, the `endpoint` option is meant for overriding the default endpoint value resolved from the region option [1]. Passing a `nil` value for the endpoint option is not the same as not passing it at all, as nil is still considered to be an override [2][3]. A recent refactor to the `AwsSdkAdapter` looks to have tweaked the options logic to always include the `endpoint` key in the object being passed to `Aws::S3::Resource`. By default, this will raise a "missing required option :endpoint" exception as the default legacy option of `nil` will be set for the endpoint. This change ensures that the `endpoint` value isn't set if the legacy option is not specified. [1] https://github.com/aws/aws-sdk-ruby/blob/c97f6932b6d5d6bc3e45aaf1068be52afd6781be/gems/aws-sdk-core/lib/seahorse/client/plugins/endpoint.rb#L11-L15 [2] https://github.com/aws/aws-sdk-ruby/blob/c97f6932b6d5d6bc3e45aaf1068be52afd6781be/gems/aws-sdk-core/lib/seahorse/client/plugins/endpoint.rb#L29-L32 [3] aws/aws-sdk-ruby#2066
…ve a value, and only if it is not already set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#389 extended. I didn't have permissions to push to the remote branch.