Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FogAdapter #138

Merged
merged 1 commit into from
Mar 4, 2014
Merged

Add FogAdapter #138

merged 1 commit into from
Mar 4, 2014

Conversation

laurynas
Copy link

FogAdapter is based on S3Adapter, just more flexible and can be easily used with RackSpace or other CDNs supported by Fog. No need for CarrierWave which used Fog itself.

@kjvarga
Copy link
Owner

kjvarga commented Feb 5, 2014

The S3Adapter only uses Fog. It's the WaveAdapter that uses CarrierWave. Can you take another look at the S3Adapter source and confirm that it does what you want?

The docs around the adapters suck. So I apologize if your confusion was because of that.

Thanks

@laurynas
Copy link
Author

laurynas commented Feb 5, 2014

Hi, the problem with S3Adapter is that it is restricted to AWS. Credentials to FOG are passed as aws_access_key_id and aws_secret_access_key. With these restrictions it is impossible to use it with Rackspace (or I didn't find the way). FogAdapter solves this issue as configuration is forwarded directly to Fog::Storage so you have full Fog control.

@kjvarga
Copy link
Owner

kjvarga commented Feb 5, 2014

Gotcha. Ok it looks good. I'd probably have to remove the file deletion bit as I read the file size to output the summary line.

Thanks for the contribution!

@laurynas
Copy link
Author

laurynas commented Feb 8, 2014

I think it would be good to remove temporary files after upload as they are not used anymore. Maybe statistics could be aggregated during processing?

@kjvarga kjvarga merged commit 9e378ca into kjvarga:master Mar 4, 2014
@kjvarga
Copy link
Owner

kjvarga commented Mar 4, 2014

Thanks again! Released in v5.0.1

@laurynas
Copy link
Author

laurynas commented Mar 4, 2014

Thanks! Glad to contribute 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants