More fool-proof detection of missing illustrations in library.xml #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presence of the "faviconMimeType" attribute in a book entry in library.xml file is enough for libkiwix to assume that the book contains an illustration (even if the "favicon" attribute is missing).
Now (in a library.xml flow) a book is considered to contain an illustration only if both "faviconMimeType" and "favicon" attributes are set to non-empty values.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
- Coverage 38.88% 38.87% -0.01%
==========================================
Files 56 56
Lines 3973 3974 +1
Branches 2186 2187 +1
==========================================
Hits 1545 1545
Misses 1097 1097
- Partials 1331 1332 +1
☔ View full report in Codecov by Sentry. |
mgautierfr
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #950