-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fragment value instead of search query for filters #907
Conversation
I also changed some indentation to match rest of the document |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
=======================================
Coverage 72.11% 72.11%
=======================================
Files 54 54
Lines 3766 3766
Branches 2100 2100
=======================================
Hits 2716 2716
Misses 1048 1048
Partials 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@juuz0 A brother PR should be done in kiwix-tools to upgrade documentation. |
@juuz0 Using the term "hash" is wrong (see https://stackoverflow.com/questions/2800187/what-is-it-when-a-link-has-a-pound-sign-in-it#2800195) and actually misleading (because in programming "hash" refers to hashing algoritms). Current naming is IMO appropriate and we can keep it even if we move the parameters after the pound character. |
@kelson42 Thanks, I am not sure what you mean by Do you mean keeping class name as Alternative name could be |
I looked through https://github.com/kiwix/kiwix-tools/blob/main/docs/kiwix-serve.rst |
922c455
to
d707d1a
Compare
I changed |
The filters are now taken from window.location.hash (instead of window.location.search). This change will help in caching of the page better.
Fixes #565