A better favicon.ico with correct MIME-type #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 71.95% // Head: 71.95% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
=======================================
Coverage 71.95% 71.95%
=======================================
Files 54 54
Lines 3748 3748
Branches 2100 2100
=======================================
Hits 2697 2697
Misses 1049 1049
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mgautierfr
approved these changes
Feb 10, 2023
The new unit test demonstrates that for embedded resources with .ico and .json extensions MIME-types are incorrect.
As a result, favicon.ico stopped being considered a compressible resource.
Replaced the favicon embedded in kiwix-serve with a slightly better one (taken from https://www.kiwix.org/favicon.ico).
veloman-yunkan
force-pushed
the
jsonico_mimetypes
branch
from
f783d00
to
93bb0f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #471