Suggestion link points to /content endpoint #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 71.41% // Head: 71.41% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 71.41% 71.41%
=======================================
Files 53 53
Lines 3740 3740
Branches 2077 2077
=======================================
Hits 2671 2671
Misses 1067 1067
Partials 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mgautierfr
approved these changes
Jan 3, 2023
Directly pointing the suggestion link to a /content/... URL avoids an unnecessary redirection by the server (and an associated bug related to redirection of URLs with URI-encoded special symbols in them that - in the current implementation - go into the target URL in decoded form).
mgautierfr
force-pushed
the
suggestion_link_fix
branch
from
c98d925
to
d9342ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix kiwix/kiwix-tools#589 (but a similar issue for a search result link will persist)
Directly pointing the suggestion link to a
/content/...URL avoids an unnecessary redirection by the server (and an associated bug related to redirection of URLs with URI-encoded special symbols in them that - in the current implementation - go into the target URL in decoded form).