Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multizim search is allowed only on a monolanguage set of books #838

Merged
merged 7 commits into from
Nov 1, 2022
Merged

Multizim search is allowed only on a monolanguage set of books #838

merged 7 commits into from
Nov 1, 2022

Commits on Oct 31, 2022

  1. Adios kiwix::getArchiveId()

    @veloman-yunkan
    veloman-yunkan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    7167ca1 View commit details
    Browse the repository at this point in the history

  2. Extracted InternalServer::handle_search_request()

    @veloman-yunkan
    veloman-yunkan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    9d2cc35 View commit details
    Browse the repository at this point in the history

  3. Fixed indentation

    @veloman-yunkan
    veloman-yunkan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    414d7ae View commit details
    Browse the repository at this point in the history

  4. Some clean-up

    @veloman-yunkan
    veloman-yunkan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    cd62b5d View commit details
    Browse the repository at this point in the history

  5. Preventing confusion of tongues in multizim search 

    Multizim search requires that all selected books be in the same
language.

No new URL query parameter was introduced for specifying the intended
search language - `books.filter.lang` can be used for that purpose.

The server_search unit-test was updated to use a slightly cheating
library xml file where the language of example.zim was tweaked from "en"
to "eng" in order to match that of zimfile.zim. Note that this change
drops from the tested server two other goofy ZIM files corner_cases.zim
and poor.zim that have been/are included in ServerTest.
    @veloman-yunkan
    veloman-yunkan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    9409e8b View commit details
    Browse the repository at this point in the history

  6. RequestContext preserves the exact query string 

    Before this change RequestContext::get_query() returned a reordered
query string (alphabetically sorted by the parameter names).

This fix facilitiates testing of responses where the request URL appears
in the response.
    @veloman-yunkan
    veloman-yunkan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    cb02dbd View commit details
    Browse the repository at this point in the history

  7. ServerSearchTest.searchInMultilanguageBookSetIsDenied

    @veloman-yunkan
    veloman-yunkan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    d1b8519 View commit details
    Browse the repository at this point in the history