Fix few compilation issues on windows #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a specific private non deprecated constructor especially for that, let's use it.
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
==========================================
+ Coverage 63.63% 63.66% +0.03%
==========================================
Files 59 59
Lines 4075 4073 -2
Branches 2219 2218 -1
==========================================
Hits 2593 2593
+ Misses 1480 1478 -2
Partials 2 2
Continue to review full report at Codecov.
|
mgautierfr
changed the title
|
Fixes are easy and already tested on kiwix-build side (https://ci.appveyor.com/project/Kiwix/kiwix-build/builds/43819342) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a specific private non deprecated constructor especially for that,
let's use it.