Iframe-based content viewer #716

Before this fix, browsing history didn't work at all. Now it mostly works but there are still some quirks that must be debugged further. Since session history handling turns out to be a rather complex topic (see https://html.spec.whatwg.org/multipage/history.html) the work in that direction will be postponed until other features reach a comparable level of readiness.

Javascript code inside taskbar.js doesn't work correctly with the new viewer. Will fix any issues in a clone of static/skin/taskbar.js.

Foundation for never-ending friendship between viewer_taskbar.js and viewer.html has been established by a slight change in how the book name is obtained and commenting out the rest of the code.

Added to static/skin/viewer.html the contents of static/templates/taskbar_part.html inside a comment block.

The greenish taskbar placeholder is gone. The appearance of the old taskbar is restored. However the taskbar currently contains only the library button (but the latter leads to the currently blank welcome page).

Known issues: - the placeholder text in the searchbox is incorrect

- /viewer (without any hash) dynamically redirects to the welcome page - The book links on the welcome page point to the iframe-based viewer

Before this fix there were two issues with the taskbar search box: 1. The book used for the suggestions API was resolved only once during the page load and didn't change during navigation. 2. The current book could not be resolved from a search URL. Now both issues are fixed.

- Suggestions disappear when search is performed as a result of pressing enter in the search box.

Double-toolbar in the viewer has gone. Some clean-up has to be performed after this change.

Removed the isHomePage param from one of the variants of `ContentResponse::build()`. The other overload is dangerous since failing to review&update all of its call site may result in changed semantics. Will do it in a couple of separate commits.

This resulted in compiler aided discovery of all call sites where the default values were used. For OPDS/catalog requests now passing true for the `raw` parameter, since XML content isn't supposed to undergo any transformations.

The only place that the root link is now used is in /skin/index.js, so added it in static/templates/index.html. But it seems that nothing prevents us from from switching from aboslute paths to relative paths in /skin/index.js, which will eliminate the need for the root link altogether. As a result of this change content is never decorated by kiwix serve.

Made the viewer respect the `--blockexternal` and `--nolibrarybutton` options of `kiwix-serve`. Those options are passed to the viewer via the dynamically generated resource `/viewer_settings.js`.

`--nosearchbar` option of `kiwix-serve` (despite its misleading name) was used to disable the entire taskbar. This commit accounts for the existence of that option only partially: 1. Links to books on the welcome/library page are affected - by default books are displayed in the viewer, but in a kiwix-serve instance run with --nosearchbar books are loaded in the top window. 2. The `/viewer` endpoint is enabled unconditionally, so if anyone enters the viewer URL in the address bar they will see books in the viewer.

This reverts commit 436d890.

Auto hiding of the toolbars on narrow screens works only for the first page loaded in the viewer. Navigating to other pages interferes with autohiding as follows: - If the toolbar was hidden, it stays hidden. - If the toolbar was not hidden, it loses the ability to autohide.

If `kiwix-serve` is run with the `--nosearchbar` option the toolbar is disabled (hidden) in its viewer. Note however that certain actions performed by the viewer merely with the purpose of keeping the toolbar up-to-date are still carried out.

A rebase invalidated the cacheids in the previous commits of the iframe_based_content_viewer branch. This commit fixes only the current state leaving the history with wrong cacheids - this can be an issue for `git bisect` being executed on a commit range overlapping with the iframe_based_content_viewer branch.

With taskbar no longer being injected into the responses, it doesn't make any sense testing the search on different flavours of the server.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Iframe-based content viewer #716

Iframe-based content viewer #716

Commits on Sep 21, 2022