-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iframe-based content viewer #716
Commits on Sep 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dea674e - Browse repository at this point
Copy the full SHA dea674eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4db443e - Browse repository at this point
Copy the full SHA 4db443eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5f97d9 - Browse repository at this point
Copy the full SHA e5f97d9View commit details -
Improved browsing history tracking & traversal
Before this fix, browsing history didn't work at all. Now it mostly works but there are still some quirks that must be debugged further. Since session history handling turns out to be a rather complex topic (see https://html.spec.whatwg.org/multipage/history.html) the work in that direction will be postponed until other features reach a comparable level of readiness.
Configuration menu - View commit details
-
Copy full SHA for 4105be9 - Browse repository at this point
Copy the full SHA 4105be9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 228e31c - Browse repository at this point
Copy the full SHA 228e31cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c6c315 - Browse repository at this point
Copy the full SHA 7c6c315View commit details -
viewer += static/templates/head_taskbar.html
Javascript code inside taskbar.js doesn't work correctly with the new viewer. Will fix any issues in a clone of static/skin/taskbar.js.
Configuration menu - View commit details
-
Copy full SHA for 5b545d8 - Browse repository at this point
Copy the full SHA 5b545d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58e4571 - Browse repository at this point
Copy the full SHA 58e4571View commit details -
viewer_taskbar.js + viewer.html = BFF
Foundation for never-ending friendship between viewer_taskbar.js and viewer.html has been established by a slight change in how the book name is obtained and commenting out the rest of the code.
Configuration menu - View commit details
-
Copy full SHA for f41e71b - Browse repository at this point
Copy the full SHA f41e71bView commit details -
viewer += <!--static/templates/taskbar_part.html-->
Added to static/skin/viewer.html the contents of static/templates/taskbar_part.html inside a comment block.
Configuration menu - View commit details
-
Copy full SHA for 7be7a8e - Browse repository at this point
Copy the full SHA 7be7a8eView commit details -
Enabled the library button on the taskbar
The greenish taskbar placeholder is gone. The appearance of the old taskbar is restored. However the taskbar currently contains only the library button (but the latter leads to the currently blank welcome page).
Configuration menu - View commit details
-
Copy full SHA for 0c4d9e8 - Browse repository at this point
Copy the full SHA 0c4d9e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17ff2a0 - Browse repository at this point
Copy the full SHA 17ff2a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a944671 - Browse repository at this point
Copy the full SHA a944671View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a55b13 - Browse repository at this point
Copy the full SHA 4a55b13View commit details -
Enabled searchbox in the iframe-based viewer
Known issues: - the placeholder text in the searchbox is incorrect
Configuration menu - View commit details
-
Copy full SHA for 77d9777 - Browse repository at this point
Copy the full SHA 77d9777View commit details -
Welcome page interoperates with iframe-based viewer
- /viewer (without any hash) dynamically redirects to the welcome page - The book links on the welcome page point to the iframe-based viewer
Configuration menu - View commit details
-
Copy full SHA for eadc0ac - Browse repository at this point
Copy the full SHA eadc0acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ed01e7 - Browse repository at this point
Copy the full SHA 7ed01e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9484357 - Browse repository at this point
Copy the full SHA 9484357View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29efb88 - Browse repository at this point
Copy the full SHA 29efb88View commit details -
Searchbox correctly tracks the current book
Before this fix there were two issues with the taskbar search box: 1. The book used for the suggestions API was resolved only once during the page load and didn't change during navigation. 2. The current book could not be resolved from a search URL. Now both issues are fixed.
Configuration menu - View commit details
-
Copy full SHA for 2083c39 - Browse repository at this point
Copy the full SHA 2083c39View commit details -
Hiding of the suggestions drop-down list
- Suggestions disappear when search is performed as a result of pressing enter in the search box.
Configuration menu - View commit details
-
Copy full SHA for 9a19373 - Browse repository at this point
Copy the full SHA 9a19373View commit details -
Removed old-style taskbar injection
Double-toolbar in the viewer has gone. Some clean-up has to be performed after this change.
Configuration menu - View commit details
-
Copy full SHA for 40c496d - Browse repository at this point
Copy the full SHA 40c496dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cf4850 - Browse repository at this point
Copy the full SHA 0cf4850View commit details -
Configuration menu - View commit details
-
Copy full SHA for c73e6f9 - Browse repository at this point
Copy the full SHA c73e6f9View commit details -
Removed unused param from ContentResponse::build()
Removed the isHomePage param from one of the variants of `ContentResponse::build()`. The other overload is dangerous since failing to review&update all of its call site may result in changed semantics. Will do it in a couple of separate commits.
Configuration menu - View commit details
-
Copy full SHA for c988511 - Browse repository at this point
Copy the full SHA c988511View commit details -
Undefaulted bool params of ContentResponse::build()
This resulted in compiler aided discovery of all call sites where the default values were used. For OPDS/catalog requests now passing true for the `raw` parameter, since XML content isn't supposed to undergo any transformations.
Configuration menu - View commit details
-
Copy full SHA for eb0a45b - Browse repository at this point
Copy the full SHA eb0a45bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ce36e6 - Browse repository at this point
Copy the full SHA 0ce36e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 685e7f8 - Browse repository at this point
Copy the full SHA 685e7f8View commit details -
The only place that the root link is now used is in /skin/index.js, so added it in static/templates/index.html. But it seems that nothing prevents us from from switching from aboslute paths to relative paths in /skin/index.js, which will eliminate the need for the root link altogether. As a result of this change content is never decorated by kiwix serve.
Configuration menu - View commit details
-
Copy full SHA for a674561 - Browse repository at this point
Copy the full SHA a674561View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cc677b - Browse repository at this point
Copy the full SHA 6cc677bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b81cb3a - Browse repository at this point
Copy the full SHA b81cb3aView commit details -
Made the viewer respect the `--blockexternal` and `--nolibrarybutton` options of `kiwix-serve`. Those options are passed to the viewer via the dynamically generated resource `/viewer_settings.js`.
Configuration menu - View commit details
-
Copy full SHA for 369406f - Browse repository at this point
Copy the full SHA 369406fView commit details -
Partly respecting the kiwix-serve --nosearchbar option
`--nosearchbar` option of `kiwix-serve` (despite its misleading name) was used to disable the entire taskbar. This commit accounts for the existence of that option only partially: 1. Links to books on the welcome/library page are affected - by default books are displayed in the viewer, but in a kiwix-serve instance run with --nosearchbar books are loaded in the top window. 2. The `/viewer` endpoint is enabled unconditionally, so if anyone enters the viewer URL in the address bar they will see books in the viewer.
Configuration menu - View commit details
-
Copy full SHA for 2be9ac3 - Browse repository at this point
Copy the full SHA 2be9ac3View commit details -
Revert "Partly respecting the kiwix-serve --nosearchbar option"
This reverts commit 436d890.
Configuration menu - View commit details
-
Copy full SHA for da23e4e - Browse repository at this point
Copy the full SHA da23e4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae01790 - Browse repository at this point
Copy the full SHA ae01790View commit details -
Configuration menu - View commit details
-
Copy full SHA for 796e729 - Browse repository at this point
Copy the full SHA 796e729View commit details -
Partly fixed auto-hiding of the toolbar
Auto hiding of the toolbars on narrow screens works only for the first page loaded in the viewer. Navigating to other pages interferes with autohiding as follows: - If the toolbar was hidden, it stays hidden. - If the toolbar was not hidden, it loses the ability to autohide.
Configuration menu - View commit details
-
Copy full SHA for 4e06bb6 - Browse repository at this point
Copy the full SHA 4e06bb6View commit details -
Respecting the --nosearchbar option of kiwix-serve
If `kiwix-serve` is run with the `--nosearchbar` option the toolbar is disabled (hidden) in its viewer. Note however that certain actions performed by the viewer merely with the purpose of keeping the toolbar up-to-date are still carried out.
Configuration menu - View commit details
-
Copy full SHA for cac2d21 - Browse repository at this point
Copy the full SHA cac2d21View commit details -
A rebase invalidated the cacheids in the previous commits of the iframe_based_content_viewer branch. This commit fixes only the current state leaving the history with wrong cacheids - this can be an issue for `git bisect` being executed on a commit range overlapping with the iframe_based_content_viewer branch.
Configuration menu - View commit details
-
Copy full SHA for defa387 - Browse repository at this point
Copy the full SHA defa387View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa67b45 - Browse repository at this point
Copy the full SHA fa67b45View commit details -
Dropped taskbarless test server
With taskbar no longer being injected into the responses, it doesn't make any sense testing the search on different flavours of the server.
Configuration menu - View commit details
-
Copy full SHA for 0994a8f - Browse repository at this point
Copy the full SHA 0994a8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a0f52f - Browse repository at this point
Copy the full SHA 0a0f52fView commit details