Unittests for 404 html page #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgautierfr
force-pushed
the
unittests_for_404_html_page
branch
from
b4cb047
to
80ecc77
Compare
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
=======================================
Coverage 57.97% 57.97%
=======================================
Files 54 54
Lines 3569 3569
Branches 2007 2007
=======================================
Hits 2069 2069
Misses 1499 1499
Partials 1 1 Continue to review full report at Codecov.
|
mgautierfr
approved these changes
Feb 16, 2022
This test was introduced with the purpose of testing the error message in the 404 page returned by /random for a non-existent book. The actual expected output currently present in this new unit-test is too much for that purpose and may become a maintenance burden if more tests of that kind are added.
The `ServerTest.RandomOnNonExistentBook` unit test was replaced with a more general one testing multiple 404 scenarios where the content of the body is checked too.
mgautierfr
force-pushed
the
unittests_for_404_html_page
branch
from
80ecc77
to
34d069e
Compare
I've made it (and rebased on master) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #709
This PR is part of a larger campaign of extending the kiwix-serve test-suite, so that major changes related to kiwix/kiwix-tools#59 and #650 can be implemented in a safer environment.