Add mappings for languages not given by libicu

[juuz0]

Fixes #611

There are 7,893 languages under ISO 639-3. I could not find a mapping between lang code and native names (there's this langCode vs english names but we display native names).
Instead, this just adds the languages missed by libicu in library.kiwix.org. If this way is approved, I would like to ask:

• Should the map be rather moved to C++?

[codecov]

Codecov Report

Merging #701 (4bd02f0) into master (cfab560) will increase coverage by 0.10%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
+ Coverage   57.93%   58.03%   +0.10%     
==========================================
  Files          54       54              
  Lines        3573     3584      +11     
  Branches     2010     2019       +9     
==========================================
+ Hits         2070     2080      +10     
- Misses       1502     1503       +1     
  Partials        1        1              

Impacted Files	Coverage Δ
src/server/internalServer.cpp	81.06% <ø> (ø)
src/opds_dumper.cpp	98.31% <94.11%> (-0.76%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfab560...4bd02f0. Read the comment docs.

[kelson42]

@juuz0 From a a user perspective it works as expected. I also appreciate you made an effort to identify the other languages impacted by a similar problem. I'll let @veloman-yunkan review from a code perspective, but I believe this would be more efficient to merge iso6391To3.js and iso639_3.js, this is a bit a waste of resources to have to make two HTTP requests IMO.

[veloman-yunkan]

I think you have missed the fact that loadAndDisplayOptions() is used for populating not only the list of languages but also the list of categories. Your (already merged) PR #697 suffers from the same problem (and introduces a potential bug). Please try to take the mentioned fact into account adjust this PR accordingly (as well as identify and fix the potential bug introduced by #697).

[juuz0]

I believe this would be more efficient to merge iso6391To3.js and iso639_3.js, this is a bit a waste of resources to have to make two HTTP requests IMO.

Done.

I think you have missed the fact that loadAndDisplayOptions() is used for populating not only the list of languages but also the list of categories...

Correct, done.

[veloman-yunkan]

Should the map be rather moved to C++?

Since the static resources of kiwix-serve are compiled into the executable rather than hosted separately keeping the list of additional language mappings in js file doesn't seem to have any advantage, since we can't deploy it without building (and releasing) a new version of libkiwix and kiwix-tools. Fixing getLanguageSelfName() in src/opds_dumper.cpp will be a more coherent implementation.

If we are going to merge this PR with the solution implemented in the frontend, then the order of commits should be reversed:

1. first fix the bug introduced earlier
2. then make this new enhancement correctly.

IMHO, we better quickly do 1. as a separate PR and quietly decide whether this fix will be in C++ or JS.

[kelson42]

Fixing getLanguageSelfName() in src/opds_dumper.cpp will be a more coherent implementation.

I agree with this comment.

[veloman-yunkan]

The latest changes are fine, but there is still one unresolved comment.

[veloman-yunkan]

There is no need to use fixup commit's for this small PR. Please submit the next request for review as a single-commit history.

[juuz0]

Still not ready for a new review (for those unresolved comments), will be done by today night I hope.
Added dagbani language in latest commit