Dynamic and subset loading of catalogue in kiwix-serve #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MananJethwani
force-pushed
the
adding_dynamic_and_subset_loading
branch
from
39b589f
to
03d7d4e
Compare
kelson42
changed the title
kelson42
approved these changes
May 27, 2021
There was a problem hiding this comment.
Works for me. @mgautierfr Does this PR satisfies your expectations?
MananJethwani
force-pushed
the
adding_dynamic_and_subset_loading
branch
from
03d7d4e
to
e9c69a4
Compare
MananJethwani
force-pushed
the
adding_dynamic_and_subset_loading
branch
from
e9c69a4
to
063bb8c
Compare
|
@mgautierfr I will have to merge this with or without your review (unfortunaetly), this is taking too long and the student has to tackle other tickets. |
|
Sorry for the delay. We are good. |
mgautierfr
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kelson42 @mgautierfr this fixes #511 and #514.