Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop wrappers from Internal Server #536

Merged
merged 9 commits into from
Jul 6, 2021
Merged

Drop wrappers from Internal Server #536

merged 9 commits into from
Jul 6, 2021

Commits on Jul 3, 2021

  1. Add m_archives and getArchiveById to Library 

    These members will mirror the functionality offered by equivalent usage
of Reader class.
    @maneeshpm
    maneeshpm committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    940368b View commit details
    Browse the repository at this point in the history

  2. Drop usage of Reader from InternalServer::handle_meta 

    This is essentially a code move of meta handlers from using Reader
functions to directly using Archive.
    @maneeshpm
    maneeshpm committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    7d68926 View commit details
    Browse the repository at this point in the history

  3. Drop usage of Reader from InternalServer::handle_suggest

    @maneeshpm
    maneeshpm committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    a236751 View commit details
    Browse the repository at this point in the history

  4. Drop Reader from InternalServer::handle_random

    @maneeshpm
    maneeshpm committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    75b4d31 View commit details
    Browse the repository at this point in the history

  5. Drop Reader and Entry wrappers from handle_content

    @maneeshpm
    maneeshpm committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    c046f64 View commit details
    Browse the repository at this point in the history

  6. Add SearchRenderer handles for libzim structures 

    Introduces a new member mp_search that houses the zim::Search object,
adds a new constructor for this purpose. This commit also add an
overload for getHtml that takes start and end integers as arguments
since they are not part of the search object we include.
    @maneeshpm
    maneeshpm committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    bcece66 View commit details
    Browse the repository at this point in the history

  7. Drop wrapper structures from handle_search 

    Since we now have SearcherRenderer that can work with native libzim
structure, we will drop the wrapper and use them instead.
    @maneeshpm
    maneeshpm committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    bc82163 View commit details
    Browse the repository at this point in the history

  8. Remove unwanted reader functions 

    Removing the functions in InternalServer that are no longer needed.
    @maneeshpm
    maneeshpm committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    a94a03c View commit details
    Browse the repository at this point in the history

  9. Add unit tests for Searcher and Reader 

    Even though we will be removing the wrappers soon, the test coverage
should be complete and we could simply remove these files later.
    @maneeshpm
    maneeshpm committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    6f63914 View commit details
    Browse the repository at this point in the history