Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix taskbar insertion in case of '<head>' attributes #440

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

kelson42
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #440 (8c43fd8) into master (9e032b6) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   59.67%   59.64%   -0.03%     
==========================================
  Files          51       51              
  Lines        3402     3402              
  Branches     1713     1713              
==========================================
- Hits         2030     2029       -1     
- Misses       1369     1370       +1     
  Partials        3        3              
Impacted Files Coverage Δ
src/server/response.cpp 86.66% <100.00%> (ø)
src/tools/stringTools.cpp 61.16% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e032b6...8c43fd8. Read the comment docs.

@kelson42
Copy link
Collaborator Author

Too trivial, just merging.

@kelson42 kelson42 merged commit 321d08e into master Jan 12, 2021
@kelson42 kelson42 deleted the better-taskbar-introduction branch January 12, 2021 10:49
@mgautierfr
Copy link
Member

Not so trivial, it will break <head foo="<oups>">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kiwix-serve should not be affected by ZIM's CSS
2 participants