Removed getDataDirectory()

[sgourdas]

This removes getDataDirectory() and properly modifies all its dependencies, so as to migrate it to kiwix-desktop.

• In the process, makeDirectory() is also removed after being marked as non essential.
• startDownload() now directly receives the download directory and ignores all dirs in options.

Implements #1087 and #1085

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 41.42%. Comparing base (ff6d8a4) to head (7108dfa).

Files	Patch %	Lines
src/downloader.cpp	0.00%	7 Missing ⚠️
src/aria2.cpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
+ Coverage   41.21%   41.42%   +0.20%     
==========================================
  Files          58       58              
  Lines        4258     4237      -21     
  Branches     2332     2318      -14     
==========================================
  Hits         1755     1755              
+ Misses       1014      993      -21     
  Partials     1489     1489              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sgourdas]

@veloman-yunkan is this ok?

[veloman-yunkan]

I think that the commits must be reordered - you should start with the enhancement of the Downloader::startDownload()

[sgourdas]

@veloman-yunkan how is it now?

[mgautierfr]

LGTM too