NameMapper detects (and reports) all naming conflicts #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1067 +/- ##
==========================================
+ Coverage 41.03% 41.05% +0.01%
==========================================
Files 58 58
Lines 4187 4190 +3
Branches 2303 2304 +1
==========================================
+ Hits 1718 1720 +2
Misses 1003 1003
- Partials 1466 1467 +1 ☔ View full report in Codecov by Sentry. |
Two entries in test library.xml used to point to the same file path. Note that though the third entry pointed to a different file name it is a symbolic link to the same file. Now all three entries point to pseudo-different files (having the same content behind them). This change is needed so that tests don't break when detection of conflicting book names is made stricter.
The extended setup of the NameMapper unit test demonstrates (by the fact that this change doesn't break the tests that check the stderr) that certain naming conflicts escape NameMapper's attention.
No cleanup of the new function was performed to keep the diff minimal.
- Got rid of the continue statement - Renamed the function parameter - Fixed indentation
Also this change leads to the change in the mapping (since conflicts that previously went undetected and just overwrote the existing entry are now rejected).
mgautierfr
force-pushed
the
stricter_namemapper
branch
from
1051546
to
068555d
Compare
mgautierfr
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates and addresses some issues with name mapping that were discovered while working on kiwix/kiwix-tools#596.