Default UI language is resolved in the frontend #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
=======================================
Coverage 39.34% 39.35%
=======================================
Files 58 58
Lines 4061 4060 -1
Branches 2237 2236 -1
=======================================
Hits 1598 1598
Misses 1091 1091
+ Partials 1372 1371 -1 ☔ View full report in Codecov by Sentry. |
mgautierfr
reviewed
Jan 29, 2024
|
Reminder to myself - translatewiki PR #1033 has been merged, so |
mgautierfr
approved these changes
Jan 31, 2024
|
Please rebase-fixup. |
... so that extra info about the count of translated strings can be added. Note that due to increased size skin/languages.js lost its too-small-to-be-worth-compressing status.
Note that static/skin/languages.js must be generated/updated manually by running the static/generate_i18n_resources_list.py script. Previously it had to be done only when new languages were added. Now the translation counts will also need to be updated when new entries are added to static/skin/i18n/en.json or upon merging a few translatewiki PRs.
This change eliminates any need for defaultUserLanguage in viewer_settings.js.
veloman-yunkan
force-pushed
the
default_ui_language_is_resolved_in_the_frontend
branch
from
026a55a
to
c697611
Compare
Done |
@mgautierfr Done |
mgautierfr
deleted the
default_ui_language_is_resolved_in_the_frontend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1038
Fixes #1039
This change makes the viewer resolve the default UI language in the front end, without any dependence on the backend's handling of the
Accept-Languageheader. Yet, the latter has not been removed since it is currently used in the following scenarios:/nojsendpoint/invalid_endpoint, or any other invalid kiwix-serve URL directly loaded in the browser rather than via the Kiwix JS viewer).