Control characters are escaped in suggestions JSON #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
- Coverage 38.92% 38.88% -0.04%
==========================================
Files 58 58
Lines 3990 3991 +1
Branches 2201 2204 +3
==========================================
- Hits 1553 1552 -1
Misses 1090 1090
- Partials 1347 1349 +2 ☔ View full report in Codecov by Sentry. |
kelson42
force-pushed
the
suggestions_with_control_characters
branch
from
24a2ec5
to
072257f
Compare
According to the JSON spec, control characters from U+0000 through U+001F must NOT appear in strings unescaped.
kelson42
force-pushed
the
suggestions_with_control_characters
branch
from
072257f
to
571c09e
Compare
|
Merging PR as pretty trivial and we need to release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1020
The fix is tested using only a unit test for the helper utility. No test running on real ZIM data is provided (because the problematic case is hardly represented in our test ZIM data).