Hack for mirrobrain magnet URIs #1001
Conversation
|
@veloman-yunkan thank you ; is any of the commit history worth keeping? I think it can all be squashed into one. WDYT? |
@rgaudin I concur with you on this. In fact I wanted to suggest that in my approval but didn't want to appear too finicky. :) |
rgaudin
force-pushed
the
magnet
branch
2 times, most recently
from
e5fad92
to
b41d436
Compare
|
Done ; it's rebased off |
Missing parameters are added to the magnet link for it to work properly given it is mainly based on webseeds. Each mirror serving the file is added as a webseed. Params that requires URIEncoding are now encoded. Introduces `makeURLSearchString()` to turn SearchParams into a string but only URIEncoding some specific params.
|
@veloman-yunkan @rgaudin @mgautierfr Unfortunately I can not merge because the CI is red and the error seems worrying. |
|
The cacheid has to be adapted as static files have been changed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
=======================================
Coverage 38.92% 38.92%
=======================================
Files 58 58
Lines 3990 3990
Branches 2201 2201
=======================================
Hits 1553 1553
Misses 1090 1090
Partials 1347 1347 ☔ View full report in Codecov by Sentry. |
|
@mgautierfr thanks for the explanation. @kelson42 it's now green |
As per #938, in regard to kiwix/container-images#242, this adds some processing to the creation of the
magnet:link for downloads.It mostly fixes the parameter names/values of the magnet string but also fetches the list of mirrored URLs (using metalink) to add them as alternative webseeds.
Tested with Vuze/Azureus on Windows as well as Tixati on Windows (Tixati is smart enough to retrieve metalink from the webseed and thus didn't even need the extra
ws=).Please note that while Transmission understands it's multiple webseeds, there's no support for fetching the torrent/DHT and so the download never starts. Don't be fooled 😉! I guess it's similar in most other torrent client (most of them dont support webseed magnets).
Suggestion:
target="_blank"for magnet is really annoying (leaves a blank tab open). I think it should be removed.