Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We must not add xapian include in public headers. #469

Closed
mgautierfr opened this issue Mar 19, 2021 · 0 comments · Fixed by #470
Closed

We must not add xapian include in public headers. #469

mgautierfr opened this issue Mar 19, 2021 · 0 comments · Fixed by #470
Assignees
@veloman-yunkan
Labels
bug search
Milestone
10.0.0

Comments

@mgautierfr
Copy link
Member

mgautierfr commented Mar 19, 2021 •
edited
Loading

Last PR (#460) add include #include "xapian.h" in library.h

As xapian is a internal dependency, we must not expose it in public header. I've missed that during the review.

See kiwix/kiwix-desktop#615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veloman-yunkan veloman-yunkan

Labels
bug search
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Xapian headers are not exposed through libkiwix kiwix/libkiwix
3 participants
@mgautierfr @kelson42 @veloman-yunkan