Unable to compile anymore Kiwix-Desktop

[kelson42]

$ make 
g++ -c -pipe -std=c++11 -I/usr/local/include/ -I/usr/local/include -I/usr/include/x86_64-linux-gnu -O2 -Wall -W -D_REENTRANT -fPIC -DVERSION=2.0.5 -DQT_DEPRECATED_WARNINGS -DQT_NO_DEBUG -DQT_WEBENGINEWIDGETS_LIB -DQT_WEBENGINECORE_LIB -DQT_QUICK_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_WEBCHANNEL_LIB -DQT_QML_LIB -DQT_NETWORK_LIB -DQT_POSITIONING_LIB -DQT_CORE_LIB -I. -Isubprojects/QtSingleApplication/src -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWebEngineWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtWebEngineCore -isystem /usr/include/x86_64-linux-gnu/qt5/QtQuick -isystem /usr/include/x86_64-linux-gnu/qt5/QtPrintSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtWebChannel -isystem /usr/include/x86_64-linux-gnu/qt5/QtQml -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtPositioning -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o contenttypefilter.o src/contenttypefilter.cpp
In file included from /usr/local/include/kiwix/library.h:31,
                 from src/library.h:5,
                 from src/kiwixapp.h:4,
                 from src/contenttypefilter.cpp:2:
/usr/local/include/xapian.h:31:4: error: #error Include <xapian.h> before Qt headers, or put 'CONFIG += no_keywords' in your .pro file and use Q_SLOTS instead of slots, etc
   31 | #  error Include <xapian.h> before Qt headers, or put 'CONFIG += no_keywords' in your .pro file and use Q_SLOTS instead of slots, etc
      |    ^~~~~
In file included from /usr/local/include/xapian.h:76,
                 from /usr/local/include/kiwix/library.h:31,
                 from src/library.h:5,
                 from src/kiwixapp.h:4,
                 from src/contenttypefilter.cpp:2:
/usr/local/include/xapian/keymaker.h:114:10: error: a template-id may not appear in a using-declaration
  114 |     std::vector<KeySpec> slots;
      |          ^~~~~~~~~~~~~~~
/usr/local/include/xapian/keymaker.h: In member function ‘void Xapian::MultiValueKeyMaker::add_value(Xapian::valueno, bool, const string&)’:
/usr/local/include/xapian/keymaker.h:145:7: error: expected primary-expression before ‘.’ token
  145 |  slots.push_back(KeySpec(slot, reverse, defvalue));
      |       ^
make: *** [Makefile:1004: contenttypefilter.o] Error 1

With latest libkiwix

[mgautierfr]

It is a bug in kiwix-lib, not kiwix-desktop.
Last PR (kiwix/libkiwix#460) add "xapian.h" in the public lib-kiwix's includes and we should not (as xapian is a private/internal dependency).

[kelson42]

@mgautierfr OK and we should fix things following your recommendation #616 (comment) and this probably means rollbacking my commit. At least now, Kiwix Desktop compilation is not totally broken anymore.

[kelson42]

Was a problem with libkiwix