Fix git clone on Windows

The question mark (?) is not a valid filename character on Windows. Changing to a the pound sign (#) so that this repository can still be cloned on Windows.
kiwix · Jan 18, 2023 · 59012c5 · 59012c5
1 parent 7a98878
commit 59012c5
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 15 deletions.
diff --git a/test/data/corner_cases.zim b/test/data/corner_cases.zim
diff --git a/test/data/corner_cases/c# b/test/data/corner_cases/c#
@@ -0,0 +1 @@
+c#.html
diff --git a/test/data/corner_cases/c#.html b/test/data/corner_cases/c#.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+ <head>
+  <meta charset="utf-8" />
+  <title>C#</title>
+ </head>
+ <body>
+  <p>C# (pronounced see sharp) is a general-purpose, high-level multi-paradigm programming language. C# encompasses static typing, strong typing, lexically scoped, imperative, declarative, functional, generic, object-oriented (class-based), and component-oriented programming disciplines</p>
+ </body>
+</html>
diff --git a/test/data/corner_cases/c_sharp.html b/test/data/corner_cases/c_sharp.html
@@ -0,0 +1 @@
+c#.html
diff --git a/test/data/corner_cases/wtf.html b/test/data/corner_cases/wtf.html
diff --git a/test/data/corner_cases/wtf? b/test/data/corner_cases/wtf?
diff --git a/test/data/corner_cases/wtf?.html b/test/data/corner_cases/wtf?.html
diff --git a/test/server.cpp b/test/server.cpp
@@ -1198,10 +1198,10 @@ TEST_F(ServerTest, NonEndpointUrlsAreRedirectedToContentUrls)
 
 TEST_F(ServerTest, RedirectionsToURLsWithSpecialSymbols)
 {
-  auto g = zfs1_->GET("/ROOT/content/corner_cases/wtf.html");
+  auto g = zfs1_->GET("/ROOT/content/corner_cases/c_sharp.html");
   ASSERT_EQ(302, g->status);
   ASSERT_TRUE(g->has_header("Location"));
-  ASSERT_EQ(g->get_header_value("Location"), "/ROOT/content/corner_cases/wtf%3F.html");
+  ASSERT_EQ(g->get_header_value("Location"), "/ROOT/content/corner_cases/c%23.html");
   ASSERT_EQ(getCacheControlHeader(*g), "max-age=0, must-revalidate");
   ASSERT_FALSE(g->has_header("ETag"));
 }