-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add category support to OPDS #318
Comments
It is worth noting that this information being fetched from the catalog, it won't be availble to people using catalog-less |
@rgaudin Currently category information for a catalog entry is included via the |
Similarly, the OPDS feed can be filtered using the |
@rgaudin @mgautierfr Last comments of @veloman-yunkan make sense. Is that still a valid request? Maybe we just need a proper software primitive at libkiwix level? It seems to me that we definitly need a dedicated ability to filter via category in the OPDS API. |
It depends on what we want to do with categories. I can query by category with What happens if a ZIM has So, IMO it's more of a design decision than a technical need. |
I confirm this is the plan, but this should not play a role here. The CMS generates the |
Yep, category is stored as a tag but it exposure can be different if we'd prefer |
There is several things here. I will write about all of them. We will see how to split that :) @veloman-yunkan I recommend to read this thread kiwix/libkiwix#131 and associated issues to have a historical point of view on the tag/category situation. Underscore tags (https://wiki.openzim.org/wiki/Tags)These are tags added at creation time on zim file to describe them. The global idea/plan on kiwix-serve side is to trust the information provided in library.xml and use zim tag as fallback. In #318 (comment), once must understand library.xml (or sqlite or xapian db) when it reads "catalog".
For me it is a "bug" in the zim file. The behavior is undefined. (The same as Getting the list of categories.What is missing is a way to get the list of categories present in a library. Exposure of categories.If we provide a list of category and if we allow library.xml to have different category than zim tags I would agree that we should have a different entry. But I would not modify the tag feature at all (content and query). |
@veloman-yunkan It seems we (@mgautierfr, @rgaudin and me) have reach easily an agreement:
I hope this makes sense to you? |
@kelson42 I have only one question. In the library XML will category be specified via the |
@veloman-yunkan not change foreseen in |
Why ? Just moving the category in a new opds node only is pretty useless. The purpose of moving the category as a first level attribute of a book is to potentially not relying on the tag to have the category. If we don't, we will have a new attribute to the book we can loose if we dump it to the |
Following #317, OPDS entries should include a
category
for ZIM files which matches one.The Category is fetched from the source catalog and not the ZIM files.
OPDS feed should be query-able by
category
as well.The text was updated successfully, but these errors were encountered: