Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar update for "About Kiwix" box #983

Closed
wants to merge 2 commits into from
Closed

Grammar update for "About Kiwix" box #983

wants to merge 2 commits into from

Conversation

psypherium
Copy link
Contributor

No description provided.

@mgautierfr
Copy link
Member

Thanks for you PR @psypherium

I agree with your proposed changes. However, can you squash your commits to have only one commit in the PR ?
Rebasing (not merging) your master branch on top of our main branch should do the work.

@psypherium
Copy link
Contributor Author

psypherium commented Aug 11, 2023

I still don't know much about git, sorry.

I can do that but it'll take a few minutes, I'll have to set up github desktop and do some stuff there, there isn't an option for any of that in the web interface.

Would the "squash and merge" or "rebase and merge" github.com options not give the desired result here? Or does this repo not allow those functions? It's probably the third option: What I did was too weird/wrong, and now neither of those will work on your end, lol.

(Github even put that new little "sync fork" button on the website, which I guess does a rebase without a new commit, to help people like me to prevent this, but I only noticed it after doing it my wrong way, lol. Usually I would delete and re-fork to get an up to date thing for a pr, I dunno why I did it the commit way.)

@kelson42 kelson42 added this to the 2.4.0 milestone Aug 11, 2023
@mgautierfr
Copy link
Member

"Squash en merge" will indeed squash all your commits into one, but it will create only one commit in master.
"Rebase and merge" is not available (probably because the branch is in your repository)

We want to keep a specific merge commit (to track which commits are part of which PR) with a "clean" git history.
(You can see the result here : https://github.com/kiwix/kiwix-desktop/network . The main branch is only composed of merge commits. And each branch is "small" and never "crossing" each other)

@kelson42 kelson42 mentioned this pull request Aug 12, 2023
@kelson42
Copy link
Collaborator

I have fixed the git revision log in #986, closing this one.

@kelson42 kelson42 closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants