libkiwix now identifies itself as libkiwix #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
force-pushed
the
kiwix2libkiwix_transition
branch
from
e915b9c
to
200ca1d
Compare
kelson42
requested changes
Sep 20, 2024
In CI build, dependencies are put in the build install location rather than in the system libs directory, hence that path must be included in the search for shared libraries. The problem seems to have been triggered by recent change in the libkiwix.pc pkg-config file which resulted in the version of some of libkiwix dependencies (recorded in libkiwix.so) being bumped up. As a result, previous/older versions of those dependencies embedded in the CI build docker image (ghcr.io/kiwix/kiwix-build_ci_focal:2024-06-03) no longer matched the requirements of libkiwix.so, whereas the up-to-date versions of those dependencies (that are downloaded during each build procedure) were not used because they were not in the search path.
veloman-yunkan
force-pushed
the
kiwix2libkiwix_transition
branch
from
200ca1d
to
482e4c6
Compare
That was tricky, but now CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on kiwix/libkiwix#1133