-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitor data directory on portable mode #1209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from user perspective
@veloman-yunkan ready for the code review
@sgourdas Might that be that settings UI about monitoring directory should be greyed, as any value will be overriden at start by the code? |
@kelson42 sure, but should that be the case only for the monitor directory? |
@sgourdas Yes, I think so... because whatever this settings is set it will be reseted at start right? For the other settings, the user can change them and they will be kept! |
@kelson42 no, that is not the case at the moment per this commit. Monitor and download directory are currently hardcoded to the data directory on every portable start. What would the desired behavior be? |
Then I guess both should be greyed in portable mode (only). |
@kelson42 I added immutability on these two in portable mode. It includes grayed out text, disabled buttons and tooltip to explain the disabling. |
@sgourdas LGTM, please rebase so we can proceed with merging. |
d2c37ed
to
c6da2d4
Compare
c6da2d4
to
adc5c9c
Compare
This simplifies the creation of a portable USB by automatically monitoring the data directory in portable mode. This way we allow the user to just place needed .zim files in the data folder and the app will handle the rest.
Fixes #461