Always use api 21 for android ndk. #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmap64 is supported only from api 21 (https://android.googlesource.com/platform/ndk/+/master/docs/user/common_problems.md) Let's move to api 21 all the time.
|
About 5% of our users use an API version less than 21. won't this not work for them? |
|
@mhutti1 @mgautierfr That seems to be a good candidate to explain kiwix/kiwix-android#825 |
|
@mgautierfr @mhutti1 Do we wait something additional to merge this? |
|
This is superseded by #231 and openzim/libzim#178. Once theses two PR will be merged we will use mmap when possible and fallback to "classical" memory copy/read on android 32 bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmap64 is supported only from api 21
(https://android.googlesource.com/platform/ndk/+/master/docs/user/common_problems.md)
Let's move to api 21 all the time.