-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use progress bar with timer updates for live activities #1126
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1126 +/- ##
==========================================
- Coverage 25.36% 25.28% -0.09%
==========================================
Files 132 134 +2
Lines 6958 6981 +23
==========================================
Hits 1765 1765
- Misses 5193 5216 +23 ☔ View full report in Codecov by Sentry. |
The black bird part of the logo is too small, it should be like in on the app icon in the dashboard. |
|
b4ed2d9
to
b4acf04
Compare
@kelson42 the points above are addressed now, it should be good to be merged. |
@BPerlakiH CI fails :( |
Ok, I will have a look, it seems that the SDKRoot to build is too low on CI... |
c884857
to
dc10f86
Compare
@BPerlakiH Still red |
@kelson42 after merging #1128, this should be good as well. I did run a CI job on the combination of this branch and the Xcode branch here: |
dc10f86
to
9b65e7f
Compare
Fixes: #1107
Solution
I replaced the progress indicator, with a linear bar that is updating constantly, so for our users it is more smooth. We do update the "real" progress every 10 seconds, which changes the amount of downloaded values displayed above the bar, and that updates the timer below the bar, and makes the bar either speed up or slow down.
I've also added a timestamp for each update, this helps the system decide which updates can be dropped if they do queue up, so once the system "unblocks" the live activity it can apply the latest update.
I think, this is the best we can do considering the constraints that the iOS (especially above 18.0) puts on us.
The Dynamic Island updated
The compact view remained unchanged:
Localisation
Paused state
Downloads file updates
The original
DownloadService
file became too long, so I split that up by classes and moved under a new folder.