[prometheus-thanos] - Update to v0.10.1 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GuyTempleton <guy.templeton@skyscanner.net>
axdotl
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GuyTempleton guy.templeton@skyscanner.net
What this PR does / why we need it:
Realised this morning that #287 accidentally managed to bump the app version as well as the chart version (made my usual mistake of confusing the two to begin with.) Came back to correct my mistake and realised the upstream v0.10.1 release has been cut.
Pulls in the fix documented here: https://github.com/thanos-io/thanos/blob/v0.10.1/CHANGELOG.md#v0101---20200123
Note that as per the thread comment here the querier needs to be updated to this release to resolve the issue, not just the sidecar despite the release note implying this, hence why it benefits this chart.
Which issue this PR fixes
N/A
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[fluentd-elasticsearch])