Jgrgicevic/sw 593 envs

[gjuro87]

No description provided.

[lgtm-com]

This pull request introduces 1 alert when merging ee37066 into b4d01f6 - view on LGTM.com

new alerts:

• 1 for Unused import

[lgtm-com]

This pull request introduces 2 alerts when merging ec0e04a into 0e097ea - view on LGTM.com

new alerts:

• 1 for Unused import
• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request introduces 3 alerts when merging f47db5d into 923b2b5 - view on LGTM.com

new alerts:

• 3 for Unused import

[lgtm-com]

This pull request introduces 3 alerts when merging 6e4346c into 923b2b5 - view on LGTM.com

new alerts:

• 3 for Unused import

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[ghost]

Congratulations 🎉. DeepCode analyzed your code in 3.287 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.22%.

Quality metrics	Before	After	Change
Complexity	1.94 ⭐	2.22 ⭐	0.28 👎
Method Length	48.62 ⭐	52.48 ⭐	3.86 👎
Working memory	9.27 🙂	9.68 🙂	0.41 👎
Quality	74.62% 🙂	72.40% 🙂	-2.22% 👎

Other metrics	Before	After	Change
Lines	1384	1568	184

Changed files	Quality Before	Quality After	Quality Change
test/repos/tasks/test_sync_repos.py	73.89% 🙂	71.20% 🙂	-2.69% 👎
test/services/test_forms.py	83.96% ⭐	83.90% ⭐	-0.06% 👎
zoo/factories.py	54.22% 🙂	52.28% 🙂	-1.94% 👎
zoo/repos/admin.py	92.88% ⭐	85.54% ⭐	-7.34% 👎
zoo/repos/forms.py	82.96% ⭐	81.25% ⭐	-1.71% 👎
zoo/repos/gitlab.py	81.11% ⭐	82.12% ⭐	1.01% 👍
zoo/repos/models.py	89.02% ⭐	83.96% ⭐	-5.06% 👎
zoo/repos/tasks.py	67.34% 🙂	60.95% 🙂	-6.39% 👎
zoo/repos/urls.py	82.63% ⭐	75.78% ⭐	-6.85% 👎
zoo/repos/views.py	90.78% ⭐	76.74% ⭐	-14.04% 👎
zoo/services/constants.py	94.71% ⭐	93.42% ⭐	-1.29% 👎
zoo/services/forms.py	73.99% 🙂	75.01% ⭐	1.02% 👍
zoo/services/models.py	77.09% ⭐	76.73% ⭐	-0.36% 👎
zoo/services/views.py	75.41% ⭐	74.19% 🙂	-1.22% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
zoo/repos/tasks.py	sync_repos.sync_zoo_file.sync_enviroments_from_gitlab	7 ⭐	161 😞	14 😞	48.28% 😞	Try splitting into smaller methods. Extract out complex expressions
zoo/repos/tasks.py	sync_repos	14 🙂	165 😞	8 🙂	52.44% 🙂	Try splitting into smaller methods
zoo/repos/tasks.py	sync_repos.index_api	11 🙂	129 😞	11 😞	52.77% 🙂	Try splitting into smaller methods. Extract out complex expressions
zoo/services/models.py	Service.rate_according_to_sentry	1 ⭐	126 😞	16 ⛔	55.65% 🙂	Try splitting into smaller methods. Extract out complex expressions
zoo/services/forms.py	SplitArrayField.has_changed	13 🙂	72 🙂	11 😞	58.78% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

64.3% Coverage
0.0% Duplication