Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE: Stack #489

Merged
merged 1 commit into from
Nov 15, 2018
Merged

UPDATE: Stack #489

merged 1 commit into from
Nov 15, 2018

Conversation

vepor
Copy link
Contributor

@vepor vepor commented Oct 13, 2018

Added justify prop with options start, centred, end, between and around.

Removed option even from align prop.

Updated all block components with width: 100%.

If <Stack /> should be block element(display: flex), it'll have width: 100% to be fully stretched to parent's width.

Added more tests with variability.

Closes #618
Closes #623




LiveURL: https://orbit-components-update-stack.surge.sh

@vepor vepor added the Review needed Pull Requests that are considered complete label Oct 13, 2018
@vepor vepor requested a review from tomashapl October 13, 2018 09:43
@vepor vepor force-pushed the update/stack branch 5 times, most recently from f567839 to 46ee936 Compare October 18, 2018 17:47
@vepor
Copy link
Contributor Author

vepor commented Nov 13, 2018

Delete Card height: 100%

src/Stack/index.js Outdated Show resolved Hide resolved
src/Stack/consts.js Outdated Show resolved Hide resolved
src/Stack/index.js Outdated Show resolved Hide resolved
@vepor vepor force-pushed the update/stack branch 4 times, most recently from 00f7fe0 to fbfd76b Compare November 15, 2018 14:04
@tomashapl tomashapl merged commit db7567b into master Nov 15, 2018
@tomashapl tomashapl deleted the update/stack branch November 15, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review needed Pull Requests that are considered complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants