Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.4.16 #715

Merged
merged 63 commits into from
Jul 6, 2024
Merged

v4.4.16 #715

merged 63 commits into from
Jul 6, 2024

Conversation

kiwi-cam
Copy link
Owner

@kiwi-cam kiwi-cam commented Jul 6, 2024

No description provided.

banboobee and others added 30 commits August 13, 2022 13:22
* Fix switchState when resetting to defaults

---------

Co-authored-by: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Co-authored-by: banboobee <98196664+banboobee@users.noreply.github.com>
* Ignore fanSpeed key when looking for fan speeds

---------

Co-authored-by: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Co-authored-by: banboobee <98196664+banboobee@users.noreply.github.com>
* fix(Log): Correctly pass log to update checker

fixes #601

* chore: Fix linting errors

---------

Co-authored-by: Cameron <32912464+kiwi-cam@users.noreply.github.com>
Co-authored-by: banboobee <98196664+banboobee@users.noreply.github.com>
To prevent false low battery warnings
Co-authored-by: banboobee <98196664+banboobee@users.noreply.github.com>

* Serialize command sequence to enable last pause command.
* Sync channel selection when powered on.
* Resolve the workaround of #440.
Versions got corrupted in merges
kiwi-cam and others added 29 commits June 18, 2023 12:06
…stances (#669)


* Fix for wrong command being sent or no command sent in certain circumstances

This commit fixes two separate (but related) issues:

1. If resend is set to true and target position is equal to current position, the previous implementation resulted in sending the close command.

That doesn't make sense - for example, if the window covering is already completely open, the previous implementation made it close instead of keeping it open.

2. If close->open commands are issued in rapid succession, the open command will not get sent because the target position is still equal to current position. This is not really true in reality since the window covering has already started moving by then. The previous implementation resulted in the window covering continuing to close, rather then start opening.

---------

Co-authored-by: Cameron <32912464+kiwi-cam@users.noreply.github.com>
@kiwi-cam kiwi-cam merged commit f51f96a into master Jul 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants