Skip to content

Add recipe to install ffpyplayer with many video formats support for old toolchain #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

germn
Copy link
Contributor

@germn germn commented Dec 6, 2016

Current ffpyplayer recipe supports only h264+aac (only .mp4 file format).

This is confusing (since rarely mentioned anywhere) and probably doesn't meet people expectations (if I'm going to use video, probably I want to support more formats then only .mp4). Here's some discussions/questions about it: 1, 2, 3, 4, 5.

With this PR your can specify ffpyplayer_codecs (additionally to ffpyplayer) to enable all default codecs and libx264, libshine also. I tested it on couple of videos and couldn't find any that couldn't be processed.

I'm new with bash and p4a, so I would ask you to check PR before merging. Thanks.

@germn germn changed the title Add ffpyplayer_codecs recipe to install ffpyplayer with many video formats support. Add recipe to install ffpyplayer with many video formats support for old toolchain Dec 7, 2016
@FeralBytes
Copy link
Contributor

Thanks @germn , just to be clear I am not an approval authority for Kivy; but I do appreciate this PR and your work; it was something I was going to have to fix/address in a few weeks. Now solved.

@inclement
Copy link
Member

Thanks for the PR! @FeralBytes did you test this and it works? If so I'll happily merge it, but I no longer have the old toolchain set up for testing myself.

@FeralBytes
Copy link
Contributor

@inclement I will test it and get back to you soon. I should be able to test it tonight.

@germn
Copy link
Contributor Author

germn commented Jan 9, 2017

Just to be clear, this PR is for old toolchain (pygame based), but there's also one for new toolchain (SDL2 based): #954

I guess most users more interested in second one.

@FeralBytes
Copy link
Contributor

@germn Sorry for the delay, I have very slow Internet and depend on a cell phone for my Internet. So downloading the Android SDK & NDK took some time. I am still going to test this and yes i realize it is for the pygame tool chain.

@FeralBytes
Copy link
Contributor

@germn Now that I have everything in place; to run this and specifically test it; I just add "ffpyplayer_codecs" to the requirements in buildozer.spec correct? Or will it just work with an old toolchain build?

@germn
Copy link
Contributor Author

germn commented Jan 13, 2017

@FeralBytes to enable more video formats support your just need to add also "ffpyplayer_codecs" to buildozer, for example:

requirements = hostpython, kivy, ffpyplayer, ffpyplayer_codecs, openssl

@FeralBytes
Copy link
Contributor

FeralBytes commented Jan 23, 2017

I am sorry I did not mean to press comment.
I have finished my testing so far for today.
The code does not work for me @germn.
It crashes with a debug traceback but no real error but it is related to playing the song. I will attach in the next comment. I hope it is not my error.

@FeralBytes
Copy link
Contributor

FeralBytes commented Jan 23, 2017

Removed Error Logs Polluting PR.

@germn
Copy link
Contributor Author

germn commented Jan 23, 2017

@FeralBytes can you provide file you tested with? It would be cool also to see some example project to reproduce error.

@germn
Copy link
Contributor Author

germn commented Jan 23, 2017

[INFO ] [Kivy ] v1.9.1
[INFO ] [ImageLoaderFFPy] Using ffpyplayer 3.2

Sorry, I didn't mention it clearly, but it makes sense to test with kivy==master and latest commit in this PR. In this case versions should be Kivy: v1.9.2-dev0 and ffpyplayer 4.0.1.dev0.

Just to be clear: did code/file you tested work before this PR?

@FeralBytes
Copy link
Contributor

FeralBytes commented Jan 23, 2017

@germn give me some more time; then and I will validate everything.
Also sorry about that; not pulling master was an error on my part, I will also make sure it is pulling latest ffpyplayer.

@FeralBytes
Copy link
Contributor

FeralBytes commented Jan 24, 2017

Removed Error Logs Polluting PR.

@FeralBytes
Copy link
Contributor

@germn I just confirmed with another Ubuntu 16.04 user that the old tool chain is also broken for him @Bakterija ... I use LM 18 but it pulls as a base from Ubuntu 16.04.
As such I will have to download an older version of LM or Ubuntu before I can test this PR for you.
What is your OS and version?

@FeralBytes
Copy link
Contributor

@germn What is your OS and version?
Also I have downloaded LM 17.3 and will setup a virtual machine soon to be able to test your PR on soon.

@germn
Copy link
Contributor Author

germn commented Jan 26, 2017

@FeralBytes I'm using Ubuntu 16.04 LTS inside Virtual box.

Just to be clear: am I understanding correctly, that kivy==master with old toolchain (and without ffpyplayer at all) is broken for you right now?

@FeralBytes
Copy link
Contributor

@germn Yes.
With this error:
error: build/lib.linux-x86_64-2.7/kivy/include/config.h: No such file or directory

@FeralBytes
Copy link
Contributor

@germn looks like you will need someone else to test until I get Kivy sorted out. I am currently just trying to get any Kivy APK to work; with no success for any of the methods or build chains. I am even using VM's.

@germn
Copy link
Contributor Author

germn commented Oct 8, 2017

Since old toolchain is outdated I'll close this PR.

@germn germn closed this Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants