Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer avdmanager from cmdline-tools #2593

Merged
merged 1 commit into from
May 14, 2022
Merged

Prefer avdmanager from cmdline-tools #2593

merged 1 commit into from
May 14, 2022

Conversation

dbnicholson
Copy link
Contributor

The Android SDK tools are deprecated in favor of the command line tools.
Trying to use avdmanager from the deprecated tools fails on OpenJDK 11
with since it can't find the javax/xml/bind/annotation/XmlSchema
class. Try cmdline-tools/latest/bin/avdmanager first.

@dbnicholson
Prefer avdmanager from cmdline-tools
d71ef6a 
The Android SDK tools are deprecated in favor of the command line tools.
Trying to use avdmanager from the deprecated tools fails on OpenJDK 11
with since it can't find the `javax/xml/bind/annotation/XmlSchema`
class. Try `cmdline-tools/latest/bin/avdmanager` first.
@dbnicholson
Copy link
Contributor Author

This could definitely be better by looking for other versions of cmdline-tools instead of just latest.

AndreMiras
AndreMiras approved these changes May 14, 2022
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the PR

@AndreMiras AndreMiras merged commit c9c91e8 into kivy:develop May 14, 2022
@HyTurtle
Copy link
Contributor

Slight counterpoint if it hasn't been noticed; in buildozer (will need to find where) its cmdline-tools that are unzipped to the tools location, so may be a slight breaking change caused there.

@dbnicholson dbnicholson deleted the cmdline-tools-avdmanager branch May 14, 2022 19:20
@dbnicholson
Copy link
Contributor Author

I think that should be fine since it still falls back to that location. Our project has a similar non-standard setup that it promotes, but I think if you follow the way sdkmanager does the installs, this is how it should look.

@dbnicholson dbnicholson mentioned this pull request May 31, 2022
Open
SomberNight added a commit to SomberNight/python-for-android that referenced this pull request Oct 6, 2022
@SomberNight
android sdk tools: adapt path to file hierarchy changes
a42a1e6 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [0][1],
use a different path structure.
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy#2540
kivy#2593
SomberNight added a commit to SomberNight/buildozer that referenced this pull request Oct 6, 2022
@SomberNight
android sdk tools: adapt path to file hierarchy changes
4267f06 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy/python-for-android#2540
kivy/python-for-android#2593
SomberNight added a commit to SomberNight/python-for-android that referenced this pull request Oct 6, 2022
@SomberNight
android sdk tools: adapt path to file hierarchy changes
de79cc9 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy#2540
kivy#2593
This was referenced Oct 6, 2022
Open
Open
SomberNight added a commit to SomberNight/python-for-android that referenced this pull request Oct 6, 2022
@SomberNight
android sdk tools: adapt path to file hierarchy changes
50546ff 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy#2540
kivy#2593
SomberNight added a commit to SomberNight/python-for-android that referenced this pull request Oct 10, 2022
@SomberNight
android sdk tools: adapt path to file hierarchy changes
0849c57 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy#2540
kivy#2593
SomberNight added a commit to SomberNight/buildozer that referenced this pull request Oct 10, 2022
@SomberNight
android sdk tools: adapt path to file hierarchy changes
8791a52 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy/python-for-android#2540
kivy/python-for-android#2593
SomberNight added a commit to SomberNight/python-for-android that referenced this pull request Oct 14, 2022
@SomberNight
android sdk tools: adapt path to file hierarchy changes
0aad98b 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy#2540
kivy#2593
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Oct 18, 2022
@SomberNight @accumulator
android sdk tools: adapt path to file hierarchy changes
44cf9f9 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy#2540
kivy#2593
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Jan 5, 2023
@SomberNight @accumulator
android sdk tools: adapt path to file hierarchy changes
d7a98b0 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy#2540
kivy#2593
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Jan 5, 2023
@SomberNight @accumulator
android sdk tools: adapt path to file hierarchy changes
7217b6f 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy#2540
kivy#2593
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Jan 6, 2023
@SomberNight @accumulator
android sdk tools: adapt path to file hierarchy changes
098098f 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy#2540
kivy#2593
@gruve-p
Copy link
Contributor

gruve-p commented Feb 10, 2023

This seems to cause issues for several users:
https://stackoverflow.com/questions/75405703/python-for-android-attributeerror-avdmanager-bug-when-building-with-buildozer

https://github.com/Groestlcoin/electrum-grs/actions/runs/4142937521/jobs/7164201570

@dbnicholson
Copy link
Contributor Author

Looks like sh.Command broke it's API and started decoding the output. This PR didn't cause that.

@dbnicholson
Copy link
Contributor Author

Yep. https://github.com/amoffat/sh/blob/develop/MIGRATION.md#return-value-now-a-true-string. Probably want to pin that to 1.* for now.

@HyTurtle HyTurtle mentioned this pull request Feb 10, 2023
Merged
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Jun 30, 2023
@SomberNight @accumulator
android sdk tools: adapt path to file hierarchy changes
f517289 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy#2540
kivy#2593
accumulator pushed a commit to accumulator/buildozer that referenced this pull request Oct 6, 2023
@SomberNight @accumulator
android sdk tools: adapt path to file hierarchy changes
ce4f225 
Recent Android SDK tools, including e.g. "8092744" and "8512546" [1][2],
use a different path structure than e.g. "6514223" [0].
E.g. `sdkmanager` in older sdk tools used to be located at
  ${ANDROID_SDK_HOME}/tools/bin/sdkmanager
but now it is at
  ${ANDROID_SDK_HOME}/cmdline-tools/bin/sdkmanager

[0]: https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip
[1]: https://dl.google.com/android/repository/commandlinetools-linux-8092744_latest.zip
[2]: https://dl.google.com/android/repository/commandlinetools-linux-8512546_latest.zip

Related:
kivy/python-for-android#2540
kivy/python-for-android#2593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbnicholson @HyTurtle @gruve-p @AndreMiras