PyZQM recipe needs setuptools, list it explicitly in deps #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
previously approved these changes
Jan 7, 2021
Comment on lines
13
to
14
| version = 'master' | ||
| url = 'https://github.com/zeromq/pyzmq/archive/{version}.zip' |
There was a problem hiding this comment.
Could we take the opportunity to pin this version to last release so our builds are more reproducible?
Suggested change
| version = 'master' | |
| url = 'https://github.com/zeromq/pyzmq/archive/{version}.zip' | |
| version = '20.0.0' | |
| https://github.com/zeromq/pyzmq/archive/v{version}.zip |
vesellov
pushed a commit
to vesellov/python-for-android
that referenced
this pull request
Feb 10, 2021
* try installing setuptools first * use specific pyzmq version tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be no longer automagically available at this build stage (maybe some order of operations got changed)