Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specify --numeric-version with APK_NUMERIC_VERSION env #2210

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zebra-lucky
Copy link

  • add default=os.environ.get('APK_NUMERIC_VERSION', None) to --numeric-version argument

@AndreMiras
Copy link
Member

Thanks @zebra-lucky for the PR.
The code looks OK, but apart from not having unit tests I have mixed feelings about this feature 🤔
It basically introduces inconsistencies in the way we deal with arguments has it would be the only argument of this file that comes with "hybrid" way of setting it up.
I suppose this is a follow-up from kivy/buildozer#1079, but I'm wondering why didn't we do with a normal buildozer.spec file parameter rather than with environment variable?
I'm not completely against the feature however, just need to think and discuss it further.
I'm wondering what @inclement thinks about it too

@zebra-lucky
Copy link
Author

zebra-lucky commented May 23, 2020

I suppose this is a follow-up from kivy/buildozer#1079, but I'm wondering why didn't we do with a normal buildozer.spec file parameter rather than with environment variable?

For me env approach is more flexible and versionCode can be calculated with use of other build env variables (APP_ANDROID_ARCH=arm64-v8a as example).

Additionally it was simle to add changes)

І'l look how to add unit testing tonight.

@obfusk
Copy link
Contributor

obfusk commented Aug 3, 2020

buildozer now supports setting APP_ANDROID_NUMERIC_VERSION.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants